You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/20 19:10:36 UTC
[GitHub] [iceberg] rdblue opened a new pull request #4174: Python: Reuse types with __new__
rdblue opened a new pull request #4174:
URL: https://github.com/apache/iceberg/pull/4174
This is based on #4016. I would have opened a PR against that branch, but for some reason github wouldn't let me.
This fixes the remaining minor issues from that branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4174: Python: Reuse types with __new__
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4174:
URL: https://github.com/apache/iceberg/pull/4174#issuecomment-1047381823
LGTM! I think it'd be helpful to describe the design we settled on here to achieve singleton behavior, possibly in the module level docstring. That's nothing that needs to hold this PR up though and actually I can include that in a future PR I'm planning which adds docstrings in some other files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4174: Python: Reuse types with __new__
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4174:
URL: https://github.com/apache/iceberg/pull/4174#issuecomment-1046302323
@CircArgs, FYI. I tried to open a PR against your branch, but I couldn't so I had to create a new PR.
Feel free to pick the changes into your branch if you want to commit the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4174: Python: Reuse types with __new__
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4174:
URL: https://github.com/apache/iceberg/pull/4174#issuecomment-1048052143
Closing in favor of #4016.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #4174: Python: Reuse types with __new__
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #4174:
URL: https://github.com/apache/iceberg/pull/4174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org