[GitHub] [kafka] mjsax commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #13565:
URL: https://github.com/apache/kafka/pull/13565#discussion_r1166094148


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -539,6 +540,10 @@ public <K1> KStream<K1, V> toStream(final KeyValueMapper<? super K, ? super V, ?
 
     @Override
     public KTable<K, V> suppress(final Suppressed<? super K> suppressed) {
+        if (graphNode.isOutputVersioned().isPresent() && graphNode.isOutputVersioned().get()) {

Review Comment:
   This eager check might not be necessary, and only works if the upstream node is materialized. We could also remove it, but it might give a better stacktrace if we have it.
   
   Otherwise, the error only surfaced from `build()` was is harder to reason about.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org