You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/10/08 06:49:04 UTC
Review Request 26436: Avoid docker inspect on each usage call
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Avoid docker inspect on each usage call
Diffs
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55807
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26436/#comment96184>
__usage is a continuation call from _usage.
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26436/#comment96185>
It's necessary because the container can be removed in between any callbacks.
- Timothy Chen
On Oct. 8, 2014, 4:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 4:51 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55767
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26436]
All tests passed.
- Mesos ReviewBot
On Oct. 8, 2014, 4:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 4:51 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 9, 2014, 7:07 a.m., Michael Park wrote:
> > LGTM, leaving `Ship It`s for committers.
Thanks for reviewing! You did catch very good spots.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55956
-----------------------------------------------------------
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55956
-----------------------------------------------------------
LGTM, leaving `Ship It`s for committers.
- Michael Park
On Oct. 8, 2014, 6:43 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 6:43 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55955
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26436/#comment96314>
Can we make the container here `const`? We don't actually do any modification on it in this function.
- Michael Park
On Oct. 8, 2014, 6:43 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 6:43 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55867
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26436]
All tests passed.
- Mesos ReviewBot
On Oct. 8, 2014, 6:43 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 6:43 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56356
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26436]
All tests passed.
- Mesos ReviewBot
On Oct. 12, 2014, 5:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 5:16 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review57257
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26610, 26861, 26862, 26896, 26897, 26898, 26517, 26436]
All tests passed.
- Mesos ReviewBot
On Oct. 17, 2014, 11:24 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 11:24 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a29489
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review57305
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Oct. 17, 2014, 11:24 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 11:24 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a29489
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review58946
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26610, 26861, 26862, 26896, 26897, 26898, 26517, 26436]
All tests passed.
- Mesos ReviewBot
On Oct. 29, 2014, 12:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 12:26 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a29489
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 12:26 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 11:24 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs
-----
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 11:24 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 12, 2014, 5:16 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote:
> > Why not do it the same way that 'update' does it?
>
> Timothy Chen wrote:
> It's pretty much the same, except I named the last method containerUsage instead of __usage, based on Mpark's comment since it's not a true deferred continuation method.
>
> Benjamin Hindman wrote:
> Neither is __update. Just FYI for folks, we've also used the _ prefix to identify where we can construct lambdas that can be locally scoped. More importantly, however, the value in matching 'update' is because having consistent patterns makes it easier for people to understand the code when debugging or refactoring.
Make sense, I was confused a bit as well. Let me change it back
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56301
-----------------------------------------------------------
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote:
> > Why not do it the same way that 'update' does it?
>
> Timothy Chen wrote:
> It's pretty much the same, except I named the last method containerUsage instead of __usage, based on Mpark's comment since it's not a true deferred continuation method.
Neither is __update. Just FYI for folks, we've also used the _ prefix to identify where we can construct lambdas that can be locally scoped. More importantly, however, the value in matching 'update' is because having consistent patterns makes it easier for people to understand the code when debugging or refactoring.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56301
-----------------------------------------------------------
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote:
> > Why not do it the same way that 'update' does it?
It's pretty much the same, except I named the last method containerUsage instead of __usage, based on Mpark's comment since it's not a true deferred continuation method.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56301
-----------------------------------------------------------
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56301
-----------------------------------------------------------
Why not do it the same way that 'update' does it?
- Benjamin Hindman
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56000
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26436]
All tests passed.
- Mesos ReviewBot
On Oct. 9, 2014, 3:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 3:56 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 6:43 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Michael Park <mc...@gmail.com>.
> On Oct. 8, 2014, 9:31 a.m., Michael Park wrote:
> > src/slave/containerizer/docker.cpp, lines 1419-1428
> > <https://reviews.apache.org/r/26436/diff/2/?file=715115#file715115line1419>
> >
> > Are these checks necessary? In both calls to `__usage` directly rather than through `defer` or something similar.
EDIT: In both calls to `__usage`_, it's called_ directly
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55772
-----------------------------------------------------------
On Oct. 8, 2014, 4:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 4:51 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review55772
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26436/#comment96166>
I've seen the pattern such as: `usage` -> `_usage` -> `__usage` for sequence of continuation functions. It doesn't seem like `__usage` in this case is actually a continuation function, but rather a refactoring of common code path. Maybe it should be named something else?
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26436/#comment96167>
Are these checks necessary? In both calls to `__usage` directly rather than through `defer` or something similar.
- Michael Park
On Oct. 8, 2014, 4:51 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26436/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 4:51 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/26436
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
>
> Diff: https://reviews.apache.org/r/26436/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26436: Avoid docker inspect on each usage call
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 4:51 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-----
src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4
Diff: https://reviews.apache.org/r/26436/diff/
Testing
-------
make check
Thanks,
Timothy Chen