You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yury Kats (Created) (JIRA)" <ji...@apache.org> on 2011/12/09 18:23:40 UTC
[jira] [Created] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
----------------------------------------------------------------------
Key: SOLR-2956
URL: https://issues.apache.org/jira/browse/SOLR-2956
Project: Solr
Issue Type: Bug
Affects Versions: 4.0
Reporter: Yury Kats
"info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
Posted by "Hoss Man (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-2956:
---------------------------
Attachment: SOLR-2956.patch
ah .. right. the existing code is being very literal about how it's configured (P is implied by F so don't output P if F is already reported)
I've updated the patch to be consistent.
> LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
> ----------------------------------------------------------------------
>
> Key: SOLR-2956
> URL: https://issues.apache.org/jira/browse/SOLR-2956
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Yury Kats
> Attachments: SOLR-2956.patch, SOLR-2956.patch
>
>
> "info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
> These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
Posted by "Yury Kats (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168408#comment-13168408 ]
Yury Kats commented on SOLR-2956:
---------------------------------
Looks good to me, except that the two getFieldFlags method would be slightly inconsistent in their reporting:
If a field is specified as omitTermFreqAndPositions=true,
getFieldFlags(SchemaField) would report it as "F"
getFieldFlags(IndexableField) would report it as "FP"
> LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
> ----------------------------------------------------------------------
>
> Key: SOLR-2956
> URL: https://issues.apache.org/jira/browse/SOLR-2956
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Yury Kats
> Attachments: SOLR-2956.patch
>
>
> "info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
> These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
Posted by "Hoss Man (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-2956.
----------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.6
Assignee: Hoss Man
Committed revision 1214540. - trunk
Committed revision 1214565. - 3x
thanks for the bug report Yury!
> LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
> ----------------------------------------------------------------------
>
> Key: SOLR-2956
> URL: https://issues.apache.org/jira/browse/SOLR-2956
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Yury Kats
> Assignee: Hoss Man
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2956.patch, SOLR-2956.patch
>
>
> "info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
> These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
Posted by "Yury Kats (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168673#comment-13168673 ]
Yury Kats commented on SOLR-2956:
---------------------------------
+1 from me. Thanks.
> LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
> ----------------------------------------------------------------------
>
> Key: SOLR-2956
> URL: https://issues.apache.org/jira/browse/SOLR-2956
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Yury Kats
> Attachments: SOLR-2956.patch, SOLR-2956.patch
>
>
> "info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
> These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2956) LukeRequestHandler: getFieldFlagsKey
is out of sync with getFieldFlags
Posted by "Hoss Man (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-2956:
---------------------------
Attachment: SOLR-2956.patch
Yury, thanks for reporting this.
while writing a test to ensure we output all the flags properly in the key, i also made the test check the flags for the fields and discovered we were in fact overlooking them in getFieldFlags(IndexableField) as well (just not in getFieldFlags(SchemaField)
Attached patch should fix these problems, and ensure that any future inconsistencies introduced in the flags should cause a test error.
(would be good to have someone else sanity check the logic i added to getFieldFlags(IndexableField))
> LukeRequestHandler: getFieldFlagsKey is out of sync with getFieldFlags
> ----------------------------------------------------------------------
>
> Key: SOLR-2956
> URL: https://issues.apache.org/jira/browse/SOLR-2956
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Yury Kats
> Attachments: SOLR-2956.patch
>
>
> "info" section returned by the LukeRequestHandler does not contain legend for OMIT_TF and OMIT_POSITIONS flags.
> These flags are checked and outputted in LukeRequestHandler#getFieldFlags, but are not outputted in LukeRequestHandler#getFieldFlagsKey.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org