You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/09/23 22:20:39 UTC
Review Request 14288: stout: cleanup strings tokenize termination condition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14288/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
Trivial cleanup of Stout's tokenize function.
Also, this is last change I needed to get Clang Static Analyzer to build and analyze Mesos on Ubuntu 13.04.
(It was complaining about offset never being read after offset = s.length();).
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed14106
Diff: https://reviews.apache.org/r/14288/diff/
Testing
-------
Thanks,
David Mackey
Re: Review Request 14288: stout: cleanup strings tokenize termination
condition
Posted by Ben Mahler <be...@gmail.com>.
> On Sept. 23, 2013, 11:19 p.m., Ben Mahler wrote:
> > Ship It!
Please mark as submitted!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14288/#review26331
-----------------------------------------------------------
On Sept. 23, 2013, 8:20 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14288/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 8:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Trivial cleanup of Stout's tokenize function.
>
> Also, this is last change I needed to get Clang Static Analyzer to build and analyze Mesos on Ubuntu 13.04.
> (It was complaining about offset never being read after offset = s.length();).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed14106
>
> Diff: https://reviews.apache.org/r/14288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request 14288: stout: cleanup strings tokenize termination
condition
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14288/#review26331
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 23, 2013, 8:20 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14288/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 8:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Trivial cleanup of Stout's tokenize function.
>
> Also, this is last change I needed to get Clang Static Analyzer to build and analyze Mesos on Ubuntu 13.04.
> (It was complaining about offset never being read after offset = s.length();).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed14106
>
> Diff: https://reviews.apache.org/r/14288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Mackey
>
>