You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "asubiotto (via GitHub)" <gi...@apache.org> on 2026/04/08 11:58:26 UTC

[PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

asubiotto opened a new pull request, #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686

   PrefixStore was incorrectly not stripping the prefix from the returned result.
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #664
   Closes #670
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   Fix regression
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   Fix + assertion in integration tests + regression test
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686#discussion_r3051341129


##########
src/prefix.rs:
##########
@@ -299,6 +301,26 @@ mod tests {
         assert_eq!(&*read_data, data)
     }
 
+    // Regression test for

Review Comment:
   the extensions of the integration test is actually sufficient, but having an additional regression test also doesn't hurt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

Posted by "asubiotto (via GitHub)" <gi...@apache.org>.
asubiotto commented on PR #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686#issuecomment-4206593958

   Thanks for the review! Can I/how do I request that this gets backported to 0.13?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

Posted by "asubiotto (via GitHub)" <gi...@apache.org>.
asubiotto commented on PR #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686#issuecomment-4206059772

   cc @crepererum 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686#issuecomment-4212937451

   None of the breaking changes for 0.14.x have landed yet, so backporting is technically not even required. I will however note this in #672 so we don't forget.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix[prefix]: strip_meta from get_opts result in PrefixStore [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum merged PR #686:
URL: https://github.com/apache/arrow-rs-object-store/pull/686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org