You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 23:36:31 UTC

[GitHub] [arrow] alamb commented on pull request #8946: ARROW-10944: [Rust] Implement min/max aggregate kernels for BooleanArray

alamb commented on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747772748


   > What would the output of max(null, false) be in the current implementation?
   
   A: Incorrect (the code in https://github.com/apache/arrow/pull/8946/commits/075277c7ae64c8d1aacf7a07c7cbf501c945570b produces `None` when the answer should be `false`).
   
   > I think correct would be
   👍 
   
   I implemented this suggestion, as well as additional tests in https://github.com/apache/arrow/pull/8946/commits/b5a14d9d857cdec41f45008f8d1b69fadaece045. Thank you @Dandandan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org