You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/26 11:15:30 UTC

[GitHub] [thrift] phxnsharp commented on pull request #2395: THRIFT-5419: Update TThreadPoolAsyncServer.Execute to be async/await

phxnsharp commented on pull request #2395:
URL: https://github.com/apache/thrift/pull/2395#issuecomment-848683562


   > 
   > 
   > > Do not put long-lived tasks on the thread pool, which causes deadlock and extreme slow performance.
   > 
   > Right, but shouldn't that be in the responsibility of the implementor?
   
   I'm not sure I follow this question. The implementor of what? If you are putting long lived tasks on the thread pool without using the [TaskCreationOptions.LongRunning](https://docs.microsoft.com/en-us/dotnet/api/system.threading.tasks.taskcreationoptions?view=net-5.0) option, you are at risk of deadlocking (at least for 1 second) everything in the system, even completely unrelated code. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org