You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by va...@apache.org on 2017/02/21 17:57:46 UTC
spark git commit: [SPARK-19626][YARN] Using the correct config to set
credentials update time
Repository: spark
Updated Branches:
refs/heads/master 280afe0ef -> 7363dde63
[SPARK-19626][YARN] Using the correct config to set credentials update time
## What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/14065, we introduced a configurable credential manager for Spark running on YARN. Also two configs `spark.yarn.credentials.renewalTime` and `spark.yarn.credentials.updateTime` were added, one is for the credential renewer and the other updater. But now we just query `spark.yarn.credentials.renewalTime` by mistake during CREDENTIALS UPDATING, where should be actually `spark.yarn.credentials.updateTime` .
This PR fixes this mistake.
## How was this patch tested?
existing test
cc jerryshao vanzin
Author: Kent Yao <ya...@hotmail.com>
Closes #16955 from yaooqinn/cred_update.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/7363dde6
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/7363dde6
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/7363dde6
Branch: refs/heads/master
Commit: 7363dde6348fd70d67a13bb4644baca7c77ac241
Parents: 280afe0
Author: Kent Yao <ya...@hotmail.com>
Authored: Tue Feb 21 09:57:40 2017 -0800
Committer: Marcelo Vanzin <va...@cloudera.com>
Committed: Tue Feb 21 09:57:40 2017 -0800
----------------------------------------------------------------------
.../org/apache/spark/deploy/yarn/security/CredentialUpdater.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/7363dde6/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
----------------------------------------------------------------------
diff --git a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
index 5df4fbd..2fdb70a 100644
--- a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
+++ b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
@@ -55,7 +55,7 @@ private[spark] class CredentialUpdater(
/** Start the credential updater task */
def start(): Unit = {
- val startTime = sparkConf.get(CREDENTIALS_RENEWAL_TIME)
+ val startTime = sparkConf.get(CREDENTIALS_UPDATE_TIME)
val remainingTime = startTime - System.currentTimeMillis()
if (remainingTime <= 0) {
credentialUpdater.schedule(credentialUpdaterRunnable, 1, TimeUnit.MINUTES)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org