[GitHub] [submarine] pingsutw commented on a change in pull request #388: SUBMARINE-610. [WEB] Refactor experiment.component

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #388:
URL: https://github.com/apache/submarine/pull/388#discussion_r480211740



##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-customized-form/experiment-customized-form.component.ts
##########
@@ -0,0 +1,368 @@
+import { Component, OnInit, Input, OnDestroy } from '@angular/core';
+import { FormArray, FormControl, FormGroup, Validators } from '@angular/forms';
+import { ExperimentSpec, Specs, SpecEnviroment, SpecMeta } from '@submarine/interfaces/experiment-spec';
+import { ExperimentService } from '@submarine/services/experiment.service';
+import { ExperimentValidatorService } from '@submarine/services/experiment.validator.service';
+import { NzMessageService } from 'ng-zorro-antd';
+import { nanoid } from 'nanoid';
+import { Subscription } from 'rxjs';
+import { ExperimentFormService } from '@submarine/services/experiment.form.service';
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */

Review comment:
       Move to the top of the file

##########
File path: submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
##########
@@ -52,7 +45,7 @@ public static void tearDown(){
 
   @Test
   public void experimentNavigation() throws Exception {
-    LOG.info("[Testacse: experimentNavigation]");
+    LOG.info("[Test case: experimentNavigation]");

Review comment:
       ```suggestion
       LOG.info("[Test case]: experimentNavigation");
   ```

##########
File path: submarine-workbench/workbench-web-ng/src/app/interfaces/modal-props.ts
##########
@@ -0,0 +1,25 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export interface ModalProps {
+  okText?: string;
+  isVisible?: boolean;
+  currentStep?: number;
+  formType?: 'customized' | 'pre';

Review comment:
       ```suggestion
     formType?: 'customized' | 'predefined';
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org