You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/09/23 12:57:28 UTC

[PR] docs(runtime): evaluate session-bound file-editing policy [maka]

Sun-GLiang opened a new pull request, #5631:
URL: https://github.com/apache/maka/pull/5631

   ## Summary
   
   Follow up on [Astro-Han's architecture suggestion](https://github.com/apache/maka/pull/5533#issuecomment-5749491758) to select the file-editing policy once at session creation, analogous to `toolMode`, instead of changing it with the active model.
   
   This draft adds a design proposal in `docs/architecture/apply-patch-session-policy-proposal.md`. It compares the current per-model policy with two session-bound alternatives: retaining provider-specific protocols, or using a fixed portable ApplyPatch contract. It describes the expected simplification of policy resolution, settings, Code Mode compatibility, and replay handling, together with the risks around patch quality, model switching, and existing sessions.
   
   **We will use controlled experiments to determine which strategy is most appropriate. No strategy is selected yet.** The plan combines deterministic compatibility tests with repeated live-model evaluations of task correctness, patch recovery, history replay, latency, tokens, and cost. Fixing the editing family alone does not eliminate provider protocol conversion; removing replay helpers or per-model controls depends on the evidence and a migration plan.
   
   Refs #5533. This PR currently changes documentation only; it does not alter runtime behavior.
   
   ## Verification
   
   - `git diff --cached --check` — passed.
   - `node scripts/asf-license-headers.mjs check` — passed.
   - Documentation reference check — all five local links resolve.
   - Reviewed the proposal against the merged ApplyPatch profile selection, replay conversion, and session creation code.
   - Runtime tests, full workspace lint/typecheck, and live-model experiments have not been run for this documentation-only draft. No experiment results are claimed.
   
   ## Work remaining before a strategy decision
   
   - [ ] Agree on the candidate policies, supported switch matrix, and legacy-session behavior.
   - [ ] Define the evaluation corpus, repetitions, quality margin, and cost/latency limits before comparison.
   - [ ] Prototype the candidates behind an experimental switch and add deterministic compatibility tests, including Code Mode, resume/fork, and mixed histories.
   - [ ] Run paired, repeated live-model experiments, including weaker patch models and cross-provider switches.
   - [ ] Publish results and select a strategy, or retain the baseline if the evidence is inconclusive.
   - [ ] Document the chosen migration and settings behavior before implementing production changes or removing replay helpers.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex drafted the architecture proposal, experiment plan, and PR description, and checked documentation references and repository license headers. The documentation commit includes a `Generated-by` trailer; retain it if squashing.
   
   ## Checklist
   
   - [ ] Tests cover the change and fail without it — not applicable to this documentation-only draft; implementation tests are tracked above.
   - [ ] Lint, format, typecheck and the affected suites pass locally — full workspace checks were not run; the documentation checks performed are listed above.
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] docs(runtime): evaluate session-bound file-editing policy [maka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5631:
URL: https://github.com/apache/maka/pull/5631#issuecomment-6379486073

   <!-- maka-lifecycle:stale-warning -->
   This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed.
   
   Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the `pinned` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] docs(runtime): evaluate session-bound file-editing policy [maka]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@maka.apache.org>.
github-actions[bot] closed pull request #5631: docs(runtime): evaluate session-bound file-editing policy
URL: https://github.com/apache/maka/pull/5631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] docs(runtime): evaluate session-bound file-editing policy [maka]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@maka.apache.org>.
github-actions[bot] commented on PR #5631:
URL: https://github.com/apache/maka/pull/5631#issuecomment-6552995192

   <!-- maka-lifecycle:stale-close -->
   This pull request has been closed because it received no new commits during the 7-day grace period. This is not a judgement on the merit of the change; it only keeps the review queue aligned with work that is actively in flight.
   
   The branch and review history are preserved. Push a new commit and reopen the pull request whenever the work is ready to continue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org