You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/15 03:13:41 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3055: Integrate nuttx and pysimCoder
xiaoxiang781216 commented on a change in pull request #3055:
URL: https://github.com/apache/incubator-nuttx/pull/3055#discussion_r594022494
##########
File path: boards/arm/stm32f7/nucleo-144/src/stm32_can.c
##########
@@ -0,0 +1,134 @@
+/****************************************************************************
+ * boards/arm/stm32f7/nucleo-144/src/stm32_can.c
+ *
+ * Copyright (C) 2018 Gregory Nutt. All rights reserved.
Review comment:
need change to apache copyright
##########
File path: boards/arm/stm32f7/nucleo-144/src/nucleo-144.h
##########
@@ -181,15 +181,32 @@
/* GPIO pins used by the GPIO Subsystem */
-#define BOARD_NGPIOIN 1 /* Amount of GPIO Input pins */
-#define BOARD_NGPIOOUT 1 /* Amount of GPIO Output pins */
+#define BOARD_NGPIOIN 4 /* Amount of GPIO Input pins */
Review comment:
align the code with other line
##########
File path: boards/arm/stm32f7/nucleo-144/src/stm32_qencoder.c
##########
@@ -0,0 +1,83 @@
+/****************************************************************************
+ * boards/arm/stm32f7/nucleo-144/src/stm32_qencoder.c
+ *
+ * Copyright (C) 2012 Gregory Nutt. All rights reserved.
Review comment:
need change to apache copyright
##########
File path: boards/arm/stm32f7/nucleo-144/configs/f746-pysim/Make.defs
##########
@@ -0,0 +1,80 @@
+############################################################################
+# boards/arm/stm32f7/nucleo-144/configs/f746-pysim/Make.defs
+#
+# Copyright (C) 2016 Gregory Nutt. All rights reserved.
+# Authors: Gregory Nutt <gn...@nuttx.org>
+# Mark Olsson <po...@markolsson.se>
+# David Sidrane <da...@nscdg.com>
+#
+# Redistribution and use in source and binary forms, with or without
Review comment:
need change to apache copyright
##########
File path: boards/arm/stm32f7/nucleo-144/configs/f746-pysim/defconfig
##########
@@ -0,0 +1,1714 @@
+#
+# Automatically generated file; DO NOT EDIT.
+# NuttX/x86_64 Configuration
+#
+
+#
+# Build Setup
Review comment:
need normialize by:
./tools/refresh.sh --silent nucleo-144:f746-pysim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org