[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

[squito <gi...@git.apache.org>]

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17088#discussion_r106330358
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1331,7 +1328,14 @@ class DAGScheduler(
     
               // TODO: mark the executor as failed only if there were lots of fetch failures on it
               if (bmAddress != null) {
    -            handleExecutorLost(bmAddress.executorId, filesLost = true, Some(task.epoch))
    +            if (!env.blockManager.externalShuffleServiceEnabled) {
    --- End diff --
    
    I think these two cases are reversed, aren't they?
    
    Its a bit harder to keep straight with a negation in there, rather than switch the bodies, I'd just change it to `if (env.blockManager.externalShuffleServiceEnabled)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org