You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2018/06/08 14:03:00 UTC

[jira] [Resolved] (STORM-3098) Fix bug in filterChangingBlobsFor() in Slot.java

     [ https://issues.apache.org/jira/browse/STORM-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans resolved STORM-3098.
----------------------------------------
    Resolution: Fixed

Great work finding this.  I merged the fix into master.

> Fix bug in filterChangingBlobsFor() in Slot.java
> ------------------------------------------------
>
>                 Key: STORM-3098
>                 URL: https://issues.apache.org/jira/browse/STORM-3098
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-server
>    Affects Versions: 2.0.0
>            Reporter: Zhengdai Hu
>            Assignee: Zhengdai Hu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The following method is not implemented correctly
> {code:java}
>  private static DynamicState filterChangingBlobsFor(DynamicState dynamicState, final LocalAssignment assignment) {
>         if (!dynamicState.changingBlobs.isEmpty()) {
>             return dynamicState;
>         }
>         HashSet<BlobChanging> savedBlobs = new HashSet<>(dynamicState.changingBlobs.size());
>         for (BlobChanging rc : dynamicState.changingBlobs) {
>             if (forSameTopology(assignment, rc.assignment)) {
>                 savedBlobs.add(rc);
>             } else {
>                 rc.latch.countDown();
>             }
>         }
>         return dynamicState.withChangingBlobs(savedBlobs);
>     }
> {code}
> It doesn't modify dynamicState in anyway.
> The solution is to remove the negation in the first if statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)