You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 22:26:33 UTC
[GitHub] [arrow] jonkeane opened a new pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
jonkeane opened a new pull request #8932:
URL: https://github.com/apache/arrow/pull/8932
Ensure that the environment variables are properly passed to cmake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748348493
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747179228
Revision: bc63a029d1504617d9136ca702efdc5d23e2099b
Submitted crossbow builds: [ursa-labs/crossbow @ actions-809](https://github.com/ursa-labs/crossbow/branches/all?query=actions-809)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-809-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-809-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748354483
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746911648
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747089069
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747068849
Revision: 3f87338ceae6779b3ae2da82ab9f48431b137679
Submitted crossbow builds: [ursa-labs/crossbow @ actions-805](https://github.com/ursa-labs/crossbow/branches/all?query=actions-805)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-805-azure-test-r-rstudio-r-base-3.6-centos7)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-805-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747493444
Unfortunately it doesn't look like devtoolset is being used by arrow/R: https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=21892&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d89-0d1a-51f2-8b30-091a7a82e98c&l=46
Check in the container what `R CMD config CC` says. (cf. https://github.com/apache/arrow/blob/master/r/tools/linuxlibs.R#L307-L309) You may need to modify R's Makevars to use the devtoolset versions, or `export CC` and `CXX` in the environment that runs the tests (it would be useful to confirm that this still works, for our reference when helping users debug), or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748354947
Revision: 4643401d43b880789962e47e50e0576e341437ef
Submitted crossbow builds: [ursa-labs/crossbow @ actions-816](https://github.com/ursa-labs/crossbow/branches/all?query=actions-816)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-816-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-816-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747000983
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746615281
Revision: 5690dc804bf3f3e90ce2a1efa32268807d1dc1ad
Submitted crossbow builds: [ursa-labs/crossbow @ actions-801](https://github.com/ursa-labs/crossbow/branches/all?query=actions-801)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-801-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rstudio-r-base-3.6-centos7)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-801-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747547675
Revision: efeaf91e1ed0ade4158d7537811e00f86a216ac6
Submitted crossbow builds: [ursa-labs/crossbow @ actions-813](https://github.com/ursa-labs/crossbow/branches/all?query=actions-813)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-813-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-813-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747562922
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747064054
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748349031
Revision: ebfa883261e34a89e7e4d1840de86e6d35cea4ad
Submitted crossbow builds: [ursa-labs/crossbow @ actions-815](https://github.com/ursa-labs/crossbow/branches/all?query=actions-815)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-815-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-815-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r543741243
##########
File path: r/tools/linuxlibs.R
##########
@@ -379,40 +379,41 @@ cmake_version <- function(cmd = "cmake") {
)
}
-with_s3_support <- function(env_vars) {
+with_s3_support <- function(env_vars, cmake) {
arrow_s3 <- toupper(Sys.getenv("ARROW_S3")) == "ON" || tolower(Sys.getenv("LIBARROW_MINIMAL")) == "false"
if (arrow_s3) {
# User wants S3 support. Let's make sure they're not on gcc < 4.9
# and make sure that we have curl and openssl system libs
- info <- system(paste(env_vars, "&& $CMAKE --system-information"), intern = TRUE)
+ info <- system(paste(env_vars, cmake, "--system-information"), intern = TRUE)
Review comment:
Yeah, that _should_ work though I need to double check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746764124
Revision: 3711544fb1a2606741747affca51013e2cf4d22e
Submitted crossbow builds: [ursa-labs/crossbow @ actions-802](https://github.com/ursa-labs/crossbow/branches/all?query=actions-802)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-802-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rstudio-r-base-3.6-centos7)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-802-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r544456115
##########
File path: .env
##########
@@ -47,3 +47,4 @@ ARROW_R_DEV=TRUE
R_ORG=rhub
R_IMAGE=ubuntu-gcc-release
R_TAG=latest
+DEVTOOLSET_VERSION=-1
Review comment:
This probably deserves a comment to say that the default (negative) means not to install a devtoolset
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,16 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$R_TAG" == *centos* && "$DEVTOOLSET_VERSION" > 0 ]]; then
+ if [ "`which dnf`" ]; then
+ dnf install -y "devtoolset-$DEVTOOLSET_VERSION"
+ else [ "`which yum`" ]; then
Review comment:
If we have a devtoolset specified, we want it to install it one way or another
```suggestion
else
```
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,16 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$R_TAG" == *centos* && "$DEVTOOLSET_VERSION" > 0 ]]; then
Review comment:
We won't set this except on a centos job, so you probably don't need to check R_TAG (which I believe isn't defined at this point anyway, this script gets called in a dockerfile, and R_TAG isn't set in the dockerfile).
```suggestion
if [ "$DEVTOOLSET_VERSION" > 0 ]; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747003862
@jonkeane you can also select a subset of those jobs to run, or even individual jobs by name, so instead of `-g r`, you could do `test-r-*` and that would skip the conda and macos jobs that aren't affected by this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r544671200
##########
File path: dev/tasks/tasks.yml
##########
@@ -1766,6 +1766,16 @@ tasks:
r_tag: 3.6-centos8
not_cran: "TRUE"
+ test-r-rstudio-r-base-3.6-centos7:
Review comment:
Just to be explicit which version this is
```suggestion
test-r-rstudio-r-base-3.6-centos7-devtoolset-8:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747175673
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #8932:
URL: https://github.com/apache/arrow/pull/8932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r543737749
##########
File path: r/tools/linuxlibs.R
##########
@@ -379,40 +379,41 @@ cmake_version <- function(cmd = "cmake") {
)
}
-with_s3_support <- function(env_vars) {
+with_s3_support <- function(env_vars, cmake) {
arrow_s3 <- toupper(Sys.getenv("ARROW_S3")) == "ON" || tolower(Sys.getenv("LIBARROW_MINIMAL")) == "false"
if (arrow_s3) {
# User wants S3 support. Let's make sure they're not on gcc < 4.9
# and make sure that we have curl and openssl system libs
- info <- system(paste(env_vars, "&& $CMAKE --system-information"), intern = TRUE)
+ info <- system(paste(env_vars, cmake, "--system-information"), intern = TRUE)
Review comment:
`/path/to/cmake` is passed in as `CMAKE` in the env_vars, hence why cmake was invoked as `$CMAKE`. Would `paste("export", env_vars, "&& $CMAKE --system-information")` also solve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747125574
Revision: 0fe32e41a99a7dc2353927d93f61067a586771d3
Submitted crossbow builds: [ursa-labs/crossbow @ actions-808](https://github.com/ursa-labs/crossbow/branches/all?query=actions-808)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-808-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-808-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r545999854
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,19 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$DEVTOOLSET_VERSION" -gt 0 ]]; then
+ if [ "`which dnf`" ]; then
+ dnf install -y centos-release-scl
+ dnf install -y "devtoolset-$DEVTOOLSET_VERSION"
+ else
+ yum install -y centos-release-scl
+ yum install -y "devtoolset-$DEVTOOLSET_VERSION"
+ fi
+ echo "source scl_source enable devtoolset-$DEVTOOLSET_VERSION" >> /etc/bashrc
Review comment:
Maybe you can add `DEVTOOLSET_VERSION` to `environment` in docker-compose.yml and then (conditionally) `scl_source enable devtoolset-$DEVTOOLSET_VERSION"` in `r_test.sh`, rather than try to rely on bash profiles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-745610006
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747118974
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747563999
Revision: 0cff84e2aa1f76c911311b5464452921d70c0589
Submitted crossbow builds: [ursa-labs/crossbow @ actions-814](https://github.com/ursa-labs/crossbow/branches/all?query=actions-814)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-814-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-814-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747509072
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748359894
Aaaand it works!
https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=21985&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d89-0d1a-51f2-8b30-091a7a82e98c&l=24
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747531377
Revision: efeaf91e1ed0ade4158d7537811e00f86a216ac6
Submitted crossbow builds: [ursa-labs/crossbow @ actions-812](https://github.com/ursa-labs/crossbow/branches/all?query=actions-812)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-812-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-812-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r546117852
##########
File path: docker-compose.yml
##########
@@ -867,13 +867,15 @@ services:
args:
base: ${R_ORG}/${R_IMAGE}:${R_TAG}
r_dev: ${ARROW_R_DEV}
+ devtoolset_version: ${DEVTOOLSET_VERSION}
shm_size: *shm-size
environment:
LIBARROW_DOWNLOAD: "false"
ARROW_HOME: "/arrow"
ARROW_R_DEV: ${ARROW_R_DEV}
# To test for CRAN release, delete ^^ these two env vars so we download the Apache release
ARROW_USE_PKG_CONFIG: "false"
+ devtoolset_version: ${DEVTOOLSET_VERSION}
Review comment:
I _think_ this needs to be capitalized, it's put in the env verbatim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747498471
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748360687
Revision: 4643401d43b880789962e47e50e0576e341437ef
Submitted crossbow builds: [ursa-labs/crossbow @ actions-817](https://github.com/ursa-labs/crossbow/branches/all?query=actions-817)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-817-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-817-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746977100
Revision: f83b62e8d93b3d133092927a3bc80c06cb3e4692
Submitted crossbow builds: [ursa-labs/crossbow @ actions-803](https://github.com/ursa-labs/crossbow/branches/all?query=actions-803)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-803-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rstudio-r-base-3.6-centos7)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-803-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747090303
Revision: 3e78613efc25c4d0e6c0b03d9deef1c526948a87
Submitted crossbow builds: [ursa-labs/crossbow @ actions-806](https://github.com/ursa-labs/crossbow/branches/all?query=actions-806)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-806-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-806-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r544455545
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -39,6 +39,16 @@ if [ "$RHUB_PLATFORM" = "linux-x86_64-fedora-clang" ]; then
rm -rf $(${R_BIN} RHOME)/etc/Makeconf.bak
fi
+# Special hacking to try to reproduce quirks on centos using non-default build
+# tooling.
+if [[ "$R_TAG" == *centos* && "$DEVTOOLSET_VERSION" > 0 ]]; then
+ if [ "`which dnf`" ]; then
+ dnf install -y "devtoolset-$DEVTOOLSET_VERSION"
+ else [ "`which yum`" ]; then
Review comment:
If we have a devtoolset specified, we want it to install it one way or another (and fail hard if we can't)
```suggestion
else
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-745632804
Looks like it's doing the expected things: turning off S3 with gcc 4.9 (https://github.com/apache/arrow/pull/8932/checks?check_run_id=1560254232#step:9:24), keeping it on if it's possible (https://github.com/apache/arrow/pull/8932/checks?check_run_id=1560254241#step:9:24).
If we could construct a (nightly) test that reproduces the scenario of centos 7 but with other compilers, that would be ideal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-745610069
https://issues.apache.org/jira/browse/ARROW-10856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-745610729
Revision: c298e20fe5ae3aa2178b7474b76667c4cb33d094
Submitted crossbow builds: [ursa-labs/crossbow @ actions-795](https://github.com/ursa-labs/crossbow/branches/all?query=actions-795)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-795-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-795-azure-test-ubuntu-18.04-r-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746631619
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747187805
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-748360003
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r546119086
##########
File path: docker-compose.yml
##########
@@ -867,13 +867,15 @@ services:
args:
base: ${R_ORG}/${R_IMAGE}:${R_TAG}
r_dev: ${ARROW_R_DEV}
+ devtoolset_version: ${DEVTOOLSET_VERSION}
shm_size: *shm-size
environment:
LIBARROW_DOWNLOAD: "false"
ARROW_HOME: "/arrow"
ARROW_R_DEV: ${ARROW_R_DEV}
# To test for CRAN release, delete ^^ these two env vars so we download the Apache release
ARROW_USE_PKG_CONFIG: "false"
+ devtoolset_version: ${DEVTOOLSET_VERSION}
Review comment:
Yeah, probably. I'm going try without on crossbow to confirm while it's here and then send the push to fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-746551513
@github-actions crossbow submit -g r
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747189733
Revision: 75af9bdf5d37d36f61ec71e128d3735ae75595fd
Submitted crossbow builds: [ursa-labs/crossbow @ actions-810](https://github.com/ursa-labs/crossbow/branches/all?query=actions-810)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-810-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-810-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org