You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/04/04 21:43:35 UTC
Re: svn commit: rev 5553 - trunk/subversion/libsvn_wc
On Fri, Apr 04, 2003 at 01:36:25PM -0600, sussman@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_wc/diff.c Fri Apr 4 13:36:25 2003
> @@ -436,6 +436,7 @@
> const char *pristine_copy, *empty_file;
> svn_boolean_t modified;
> enum svn_wc_schedule_t schedule = entry->schedule;
> + svn_boolean_t copied = entry->copied;
Why does this go into a boolean variable? Why not simply test entry->copied
when you need to? The variable seems to imply that it will be, um, variable.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 5553 - trunk/subversion/libsvn_wc
Posted by Ben Collins-Sussman <su...@collab.net>.
Greg Stein <gs...@lyra.org> writes:
> On Fri, Apr 04, 2003 at 01:36:25PM -0600, sussman@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_wc/diff.c Fri Apr 4 13:36:25 2003
> > @@ -436,6 +436,7 @@
> > const char *pristine_copy, *empty_file;
> > svn_boolean_t modified;
> > enum svn_wc_schedule_t schedule = entry->schedule;
> > + svn_boolean_t copied = entry->copied;
>
> Why does this go into a boolean variable? Why not simply test entry->copied
> when you need to? The variable seems to imply that it will be, um, variable.
When I started the change, I thought I'd be using it a whole lot. I
guess I forgot to undo the complexity. :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org