You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (Created) (JIRA)" <ji...@apache.org> on 2012/01/04 02:12:39 UTC
[jira] [Created] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Specify location of log4j configuration files via configuration properties
--------------------------------------------------------------------------
Key: HIVE-2691
URL: https://issues.apache.org/jira/browse/HIVE-2691
Project: Hive
Issue Type: New Feature
Components: Configuration, Logging
Reporter: Carl Steinbach
Assignee: Zhenxiao Luo
Oozie needs to be able to override the default location of the log4j configuration
files from the Hive command line, e.g:
{noformat}
hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2691:
---------------------------------
Status: Open (was: Patch Available)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.5.patch
zhenxiao updated the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA, cwsteinbach
HIVE-2691: TestHiveHistory failure fixed
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Attachment: HIVE-2691.1.patch.txt
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.1.patch.txt, HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch, HIVE-2691.D1203.6.patch, HIVE-2691.D2667.1.patch, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.6.patch
zhenxiao updated the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA, cwsteinbach
HIVE-2691: Carl's comments addressed
initHiveLog4j() and initHiveExecLog4j() constucts their own HiveConf
Log4j init callers' code remains unchanged
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch, HIVE-2691.D1203.6.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Attachment: HIVE-2691.2.patch.txt
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.2.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Patch Available (was: Open)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Patch Available (was: Open)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.2.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Patch Available (was: Open)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184718#comment-13184718 ]
Phabricator commented on HIVE-2691:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:48 This method should not take an input parameter. Instead, look the config value up directly using HiveConf.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:52 If the logging conf file is specified using the configuration property, then you have to assume that the value is a canonical path, and you need to look it up on the local filesystem, not from the classpath.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:50 The default value for the two new conf properties is "". Checking for null will not catch this.
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java:551 Please move this code to LogUtils.initHiveExecLog4j()
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java:557 The default value of HiveConf.ConfVars.HIVE_EXEC_LOG4J_FILE is "". We should also check to make sure that the file actually exists. If it doesn't, we should use the default log conf from the classpath instead, and probably log a message explaining that we weren't able to find the conf file specified by HiveConf.
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java:566 The javadoc for PropertyConfigurator.configure(String) is a little unclear about whether or not it can handle canonical paths that specify locations which aren't on the classpath, and since it doesn't return any error information I'm not convinced that this is actually working. Please try setting the log4j.debug variable (mentioned in the javadoc) to see if you can get any diagnostic information about where it's loading the logging configuration from.
http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PropertyConfigurator.html
conf/hive-default.xml.template:1201 Both descriptions should make the following clear:
* If the property is not set, then logging will be initialized using hive-log4j.properties (or hive-exec-log4j.properties) found on the classpath.
* If the property is set, the value must be a valid URI (java.net.URI, e.g. "file:///tmp/my-logging.properties"), which you can then extract a URL from and pass to PropertyConfigurator.configure(URL).
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:63 I'm pretty sure that these logging statements are silently failing since this block of code runs before HiveConf.init() is called.
I think the cleanest solution is to add getters to HiveConf that provide access to the hiveDefaultURl and hiveSiteURL variables, and then log the same information in LogUtils.initHiveLog4j() after logging has been initialized.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:32 Change the visibility to private.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:840 I'm reversing what I said earlier. I think this code should be moved back to CliDriver, ExecDriver, etc, and initHiveLog4j/initHiveExecLog4j should take a HiveConf object as input.
REVISION DETAIL
https://reviews.facebook.net/D1203
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2691:
-----------------------------------
Status: Open (was: Patch Available)
Patch doesn't apply cleanly anymore. Zhenxiao, can you please refresh the patch.
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Open (was: Patch Available)
Found tests failure
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.4.patch
zhenxiao updated the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA, cwsteinbach
HIVE-2691: Test Failure fixed
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Patch Available (was: Open)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.3.patch
zhenxiao updated the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA, cwsteinbach
HIVE-2691: Code Cleanup
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Carl Steinbach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184714#comment-13184714 ]
Carl Steinbach commented on HIVE-2691:
--------------------------------------
@Zhenxiao: Looks like Arc is creating new review requests instead of updating your original request. Can you please verify that you are following the directions for updating review requests: https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview#PhabricatorCodeReview-UpdatingPatches%28git%29
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Attachment: HIVE-2691.D2667.1.patch
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch, HIVE-2691.D1203.6.patch, HIVE-2691.D2667.1.patch, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184530#comment-13184530 ]
Phabricator commented on HIVE-2691:
-----------------------------------
njain has commented on the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:562 Add these properties in hive-default.xml with a explanation
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:843 the 2nd log file is not used
REVISION DETAIL
https://reviews.facebook.net/D1131
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186862#comment-13186862 ]
Phabricator commented on HIVE-2691:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
INLINE COMMENTS
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:566 Shouldn't CliSessionState be initialized after logging is initialized?
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:565 Better to just call this "conf" instead of "log4jconf"
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:105 Please move this piece of code back to ExecDriver. It's out of place here.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:87 This code does not belong here.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:102 What about HIVE_EXEC_L4J?
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:119 Please change this method to return void and instead write to the log directly from this method.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:902 Remove this method. Folks can call getPath() on their own.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:55 initHiveLog4j can create its own HiveConf object, in which case you don't need to check to see if the input arg is null. I think this approach is preferable.
REVISION DETAIL
https://reviews.facebook.net/D1203
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-2691:
-------------------------------
Status: Patch Available (was: Open)
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.1.patch
zhenxiao requested code review of "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA
HIVE-2691: Specify location of log4j configuration files via configuration properties
Oozie needs to be able to override the default location of the log4j configuration
files from the Hive command line, e.g:
hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2493/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1131.1.patch
zhenxiao requested code review of "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA
HIVE-2691: Specify location of log4j configuration files via configuration properties
Oozie needs to be able to override the default location of the log4j configuration
files from the Hive command line, e.g:
hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1131
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2391/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499997#comment-13499997 ]
Zhenxiao Luo commented on HIVE-2691:
------------------------------------
Updated patch submitted at:
https://reviews.facebook.net/D6789
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.2.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2691:
-----------------------------
Status: Open (was: Patch Available)
commented on D1131
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499635#comment-13499635 ]
Zhenxiao Luo commented on HIVE-2691:
------------------------------------
@Carl and Ashutosh:
I will rebase the patch, and resubmit it soon.
Thanks,
Zhenxiao
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D2667.1.patch
zhenxiao requested code review of "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA
HIVE-2691. Specify location of log4j configuration files via configuration properties
Oozie needs to be able to override the default location of the log4j configuration
files from the Hive command line, e.g:
hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2667
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6117/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch, HIVE-2691.D1203.5.patch, HIVE-2691.D1203.6.patch, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2691:
------------------------------
Attachment: HIVE-2691.D1203.2.patch
zhenxiao updated the revision "HIVE-2691 [jira] Specify location of log4j configuration files via configuration properties".
Reviewers: JIRA, cwsteinbach
Address Carl's comments.
Move log4j configuration logic into LogUtils
HiveConf provide getters for hiveDefaultURL and hiveSiteURL
hive-site location is logged by LogUtils to sequence log/conf initialization
REVISION DETAIL
https://reviews.facebook.net/D1203
AFFECTED FILES
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
common/src/java/org/apache/hadoop/hive/common/LogUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
common/src/test/org/apache/hadoop/hive/conf/TestHiveLogging.java
common/src/test/resources/hive-exec-log4j-test.properties
common/src/test/resources/hive-log4j-test.properties
conf/hive-default.xml.template
hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch, HIVE-2691.D1203.2.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2691) Specify location of log4j
configuration files via configuration properties
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499037#comment-13499037 ]
Carl Steinbach commented on HIVE-2691:
--------------------------------------
@Zhenxiao: Please let me know if you plan to continue working on this ticket. If not I'll reassign it to someone else. Thanks.
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1131.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.4.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.5.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D1203.6.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2691.D2667.1.patch, HIVE-2691.1.patch.txt, HIVE-2691.D2667.1.patch
>
>
> Oozie needs to be able to override the default location of the log4j configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira