You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2017/02/08 18:49:37 UTC

[GitHub] couchdb-couch pull request #227: Add test_request:delete/3

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-couch/pull/227

    Add test_request:delete/3

    Sometimes it useful to be able to pass headers in test case to a delete request. 
    Adding delete/3 to be able to do so.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch add-test_requet_delete_3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #227
    
----
commit b868390528d6068c3cc837f8de8d5cfee948b285
Author: ILYA Khlopotov <ii...@apache.org>
Date:   2017-02-08T18:47:58Z

    Add test_request:delete/3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request #227: Add test_request:delete/3

Posted by iilyak <gi...@git.apache.org>.

Github user iilyak commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/227#discussion_r100145299
  
    --- Diff: src/test_request.erl ---
    @@ -51,6 +51,9 @@ delete(Url) ->
     delete(Url, Opts) ->
         request(delete, Url, [], [], Opts).
    --- End diff --
    
    @eiri: I used the same approach as in other functions get/post/put. We just call request from there. Personally I prefer the approach you suggest. Should I refactor all of them for consistency? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request #227: Add test_request:delete/3

Posted by eiri <gi...@git.apache.org>.

Github user eiri commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/227#discussion_r100148952
  
    --- Diff: src/test_request.erl ---
    @@ -51,6 +51,9 @@ delete(Url) ->
     delete(Url, Opts) ->
         request(delete, Url, [], [], Opts).
    --- End diff --
    
    fair point. I don't know, tbh, I don't feel particularly strong about it, but using smaller arity functions as defaults for same functions with bigger arity is pretty standard erlang idiom, so if you up to a bigger change I'll +1 it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request #227: Add test_request:delete/3

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch/pull/227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch issue #227: Add test_request:delete/3

Posted by iilyak <gi...@git.apache.org>.

Github user iilyak commented on the issue:

    https://github.com/apache/couchdb-couch/pull/227
  
    @eiri: done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---