You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/02/24 08:03:44 UTC
svn commit: r1784235 -
/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
Author: pmouawad
Date: Fri Feb 24 08:03:43 2017
New Revision: 1784235
URL: http://svn.apache.org/viewvc?rev=1784235&view=rev
Log:
Revert debugging code
Modified:
jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java?rev=1784235&r1=1784234&r2=1784235&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java Fri Feb 24 08:03:43 2017
@@ -111,12 +111,10 @@ public final class RemoteJMeterEngineImp
+ "\tCan be overridden by defining the system property 'java.rmi.server.hostname' - see jmeter-server script file");
}
log.debug("This = {}", this);
- Registry reg = null;
if (CREATE_SERVER){
log.info("Creating RMI registry (server.rmi.create=true)");
try {
- reg = LocateRegistry.createRegistry(this.rmiPort);
- System.err.println("Created registry: " + reg);
+ LocateRegistry.createRegistry(this.rmiPort);
} catch (RemoteException e){
String msg="Problem creating registry: "+e;
log.warn(msg);
@@ -125,13 +123,8 @@ public final class RemoteJMeterEngineImp
}
}
try {
-// if (reg == null) {
- System.err.println("Locating registry");
- reg = LocateRegistry.getRegistry(this.rmiPort);
-// }
- System.err.println("About to rebind registry: " + reg);
+ Registry reg = LocateRegistry.getRegistry(this.rmiPort);
reg.rebind(JMETER_ENGINE_RMI_NAME, this);
- System.err.println("Bound registry as: " + reg);
log.info("Bound to registry on port {}", this.rmiPort);
} catch (Exception ex) {
log.error("rmiregistry needs to be running to start JMeter in server mode. {}", ex.toString());
Re: svn commit: r1784235 - /jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
Posted by sebb <se...@gmail.com>.
On 24 February 2017 at 08:03, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Fri Feb 24 08:03:43 2017
> New Revision: 1784235
>
> URL: http://svn.apache.org/viewvc?rev=1784235&view=rev
> Log:
> Revert debugging code
-1
Only the println calls are debugging.
It does not make sense to create the registry and throw away the
instance, only to have to find it again.
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java?rev=1784235&r1=1784234&r2=1784235&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/engine/RemoteJMeterEngineImpl.java Fri Feb 24 08:03:43 2017
> @@ -111,12 +111,10 @@ public final class RemoteJMeterEngineImp
> + "\tCan be overridden by defining the system property 'java.rmi.server.hostname' - see jmeter-server script file");
> }
> log.debug("This = {}", this);
> - Registry reg = null;
> if (CREATE_SERVER){
> log.info("Creating RMI registry (server.rmi.create=true)");
> try {
> - reg = LocateRegistry.createRegistry(this.rmiPort);
> - System.err.println("Created registry: " + reg);
> + LocateRegistry.createRegistry(this.rmiPort);
> } catch (RemoteException e){
> String msg="Problem creating registry: "+e;
> log.warn(msg);
> @@ -125,13 +123,8 @@ public final class RemoteJMeterEngineImp
> }
> }
> try {
> -// if (reg == null) {
> - System.err.println("Locating registry");
> - reg = LocateRegistry.getRegistry(this.rmiPort);
> -// }
> - System.err.println("About to rebind registry: " + reg);
> + Registry reg = LocateRegistry.getRegistry(this.rmiPort);
> reg.rebind(JMETER_ENGINE_RMI_NAME, this);
> - System.err.println("Bound registry as: " + reg);
> log.info("Bound to registry on port {}", this.rmiPort);
> } catch (Exception ex) {
> log.error("rmiregistry needs to be running to start JMeter in server mode. {}", ex.toString());
>
>