You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:25:17 UTC
[GitHub] [incubator-eventmesh] pchengma opened a new pull request, #1184: [ISSUE #790] Knative Connector: Initial Implementation of Consumer.
pchengma opened a new pull request, #1184:
URL: https://github.com/apache/incubator-eventmesh/pull/1184
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixing ISSUE #790.
### Motivation
*Implemented and tested Consumer module to subscribe an event from Knative ([ISSUE #790](https://github.com/apache/incubator-eventmesh/issues/790)).*
*The PRs for [ISSUE #790](https://github.com/apache/incubator-eventmesh/issues/790) will be merged into knative-connector branch.*
### Modifications
#### Implementation
- KnativeConsumer base on **Pull** communication model
- subscribe method
- unsubscribe method
- Unit test for KnativeConsumer
- Integration test for KnativeProducer and KnativeConsumer
**Thanks @qqeasonchen and @xwm1992 for their super helpful suggestions in the design and implementation.**
#### How to Test
*Assume the cloudevents-player Knative service has already been set up on your local machine; otherwise, please follow the steps in https://knative.dev/docs/getting-started/first-source/#sending-an-event to set up a Knative service (cloudevents-player) as source and sink.*
```bash
# Set eventMesh.connector.plugin.type=knative in eventmesh-runtime/conf/eventmesh.properties
# Do integration test and subscribed event message can be seen in the console:
$ cd incubator-eventmesh/eventmesh-connector-plugin/eventmesh-connector-knative
$ ../../gradlew clean test --tests KnativeConnectorTest.testConnect -i
```
### Documentation
- Does this pull request introduce a new feature? yes.
- If yes, how is the feature documented? not documented.
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation. The documentation will be created in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] pchengma closed pull request #1184: [ISSUE #790] Knative Connector: Initial Implementation of Consumer.
Posted by GitBox <gi...@apache.org>.
pchengma closed pull request #1184: [ISSUE #790] Knative Connector: Initial Implementation of Consumer.
URL: https://github.com/apache/incubator-eventmesh/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] pchengma commented on pull request #1184: [ISSUE #790] Knative Connector: Initial Implementation of Consumer.
Posted by GitBox <gi...@apache.org>.
pchengma commented on PR #1184:
URL: https://github.com/apache/incubator-eventmesh/pull/1184#issuecomment-1228280017
@xwm1992 Please have a look when you have time. Thanks very much in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org