You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davidxdh <gi...@git.apache.org> on 2017/07/29 02:28:48 UTC

[GitHub] spark pull request #18767: [SPARK-21572][Spark Shell] Add description on how...

GitHub user davidxdh opened a pull request:

    https://github.com/apache/spark/pull/18767

    [SPARK-21572][Spark Shell] Add description on how to exit the spark-shell in the welcome message

    When the user uses the spark-shell, does not know how to exit. So we need to add description on how to exit in the welcome message.
    [https://issues.apache.org/jira/browse/SPARK-21572](https://issues.apache.org/jira/browse/SPARK-21572)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidxdh/spark dev_0729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18767
    
----
commit 95602dc2e0ccde3f2d94789307048474f2d0ae7f
Author: Donghui Xu <xu...@zte.com.cn>
Date:   2017-07-28T01:31:48Z

    Merge pull request #1 from apache/master
    
    Merge from apache/spark

commit e9274555c06e0cac70646891a00922b7590f651e
Author: davidxdh <xu...@zte.com.cn>
Date:   2017-07-29T02:26:44Z

    [SPARK-21572][Spark Shell] Add description on how to exit the spark-shell in the welcome message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18767: [SPARK-21572][Spark Shell] Add description on how to exi...

Posted by davidxdh <gi...@git.apache.org>.
Github user davidxdh commented on the issue:

    https://github.com/apache/spark/pull/18767
  
    OK. I close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18767: [SPARK-21572][Spark Shell] Add description on how to exi...

Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:

    https://github.com/apache/spark/pull/18767
  
    I’m not convinced this would be useful, could you close this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18767: [SPARK-21572][Spark Shell] Add description on how to exi...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/18767
  
    I also don't think it is worth being printed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18767: [SPARK-21572][Spark Shell] Add description on how...

Posted by davidxdh <gi...@git.apache.org>.
Github user davidxdh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18767#discussion_r130215123
  
    --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -84,6 +84,7 @@ class SparkILoop(in0: Option[BufferedReader], out: JPrintWriter)
         echo(welcomeMsg)
         echo("Type in expressions to have them evaluated.")
         echo("Type :help for more information.")
    +    echo("Type ctrl + c to exit.")
    --- End diff --
    
    Thanks for your advice. I do not think everyone knows the way to exit the scala, especially for beginner, and the clear explanation is helpful to them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18767: [SPARK-21572][Spark Shell] Add description on how...

Posted by davidxdh <gi...@git.apache.org>.
Github user davidxdh closed the pull request at:

    https://github.com/apache/spark/pull/18767


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18767: [SPARK-21572][Spark Shell] Add description on how to exi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18767
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18767: [SPARK-21572][Spark Shell] Add description on how...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18767#discussion_r130214967
  
    --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -84,6 +84,7 @@ class SparkILoop(in0: Option[BufferedReader], out: JPrintWriter)
         echo(welcomeMsg)
         echo("Type in expressions to have them evaluated.")
         echo("Type :help for more information.")
    +    echo("Type ctrl + c to exit.")
    --- End diff --
    
    Ctrl-D or `:quit` exits. Scala shell doesn't print this and I think ctrl-D is widely understood to exit processes like this. Ctrl-C is an unnecessarily hard exit but also works. Is it really unclear to anyone?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org