You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/08/05 17:48:36 UTC
svn commit: r1615950 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
Author: tilman
Date: Tue Aug 5 15:48:36 2014
New Revision: 1615950
URL: http://svn.apache.org/r1615950
Log:
PDFBOX-2257: removed BufferedInputStream wrapping that is again done in BaseParser, as suggested by Simon Steiner
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java?rev=1615950&r1=1615949&r2=1615950&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java Tue Aug 5 15:48:36 2014
@@ -16,7 +16,6 @@
*/
package org.apache.pdfbox.pdmodel;
-import java.io.BufferedInputStream;
import java.io.Closeable;
import java.io.File;
import java.io.FileInputStream;
@@ -289,7 +288,7 @@ public class PDDocument implements Close
rootPages.getAllKids(kids);
int size = (int) rootPages.getCount();
- PDPage page = null;
+ PDPage page;
if (size == 0)
{
throw new IllegalStateException("Cannot sign an empty document");
@@ -617,7 +616,7 @@ public class PDDocument implements Close
os = dest.createOutputStream();
byte[] buf = new byte[10240];
- int amountRead = 0;
+ int amountRead;
is = src.createInputStream();
while ((amountRead = is.read(buf, 0, 10240)) > -1)
{
@@ -1082,7 +1081,7 @@ public class PDDocument implements Close
*/
public static PDDocument load(File file, RandomAccess scratchFile, boolean force) throws IOException
{
- PDFParser parser = new PDFParser(new BufferedInputStream(new FileInputStream(file)), scratchFile, force);
+ PDFParser parser = new PDFParser(new FileInputStream(file), scratchFile, force);
parser.parse();
PDDocument doc = parser.getPDDocument();
doc.incrementalFile = file;
@@ -1101,7 +1100,7 @@ public class PDDocument implements Close
*/
public static PDDocument load(InputStream input, RandomAccess scratchFile) throws IOException
{
- PDFParser parser = new PDFParser(new BufferedInputStream(input), scratchFile);
+ PDFParser parser = new PDFParser(input, scratchFile);
parser.parse();
return parser.getPDDocument();
}
@@ -1120,7 +1119,7 @@ public class PDDocument implements Close
*/
public static PDDocument load(InputStream input, RandomAccess scratchFile, boolean force) throws IOException
{
- PDFParser parser = new PDFParser(new BufferedInputStream(input), scratchFile, force);
+ PDFParser parser = new PDFParser(input, scratchFile, force);
parser.parse();
return parser.getPDDocument();
}