You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/09 11:46:04 UTC
[GitHub] [camel-website] aashnajena opened a new pull request #181: Aashna
changes
aashnajena opened a new pull request #181: Aashna changes
URL: https://github.com/apache/camel-website/pull/181
Styled tables appearing in Blogs for Apache Camel Website
In response to Issue 14674 : https://issues.apache.org/jira/browse/CAMEL-14674
- added bottom margin for table
- added odd-even distinction for table rows
- added padding for table cells
- added different colour and more padding to table headers
- centre-aligned the table and text in the table
- widened the table to align with the content written around it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596534647
@aashnajena I noticed you also added changes from another issue in c8973318bad6cf8944293b4aae161927cedc488e if it's not too difficult for you can you move that to a new pull request? The reason is that we can review and merge different issues separately, making it all or nothing by bundling multiple issues in the same pull request prolongs the process and makes it difficult to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #181:
CAMEL-14674: Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena edited a comment on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596548540
Hey! I'm so sorry, the new branch I had made was branching out from this one, instead of the master. I have made a new branch from master and done the commits related to the other issue there. I have opened a new pull request for that.
What should I do about this PR? Should I revert back the changes and commit just the blog.css file again, or is it better if I close this PR and raise a new one (since changes are small, I can redo them easily)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596662547
@aashnajena I just noticed that the previous non sectioned rules remain in the blog.css, can you also remove these lines?
https://github.com/apache/camel-website/pull/181/files#diff-84ac33c1784edcb2c266b9fdc2ca36bbR156-R178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on a change in pull request
#181: CAMEL-14674: Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena commented on a change in pull request #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#discussion_r389639699
##########
File path: antora-ui-camel/src/css/blog.css
##########
@@ -99,6 +99,25 @@ article.blog p {
white-space: pre-wrap;
}
+.blog .post .post-content table {
+ width: 100%;
+ text-align: center;
+ margin-bottom: 1rem;
+}
+
+.blog .post .post-content tr:nth-child(even) {
+ background: #f4f5f7;
Review comment:
I have updated the colours from vars.css. Please take a look now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596679980
Thanks @aashnajena!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596579855
@aashnajena can I ask that you rebase this branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#181: Aashna changes
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #181: Aashna changes
URL: https://github.com/apache/camel-website/pull/181#discussion_r389618212
##########
File path: antora-ui-camel/src/css/blog.css
##########
@@ -99,6 +99,25 @@ article.blog p {
white-space: pre-wrap;
}
+.blog .post .post-content table {
+ width: 100%;
+ text-align: center;
+ margin-bottom: 1rem;
+}
+
+.blog .post .post-content tr:nth-child(even) {
+ background: #f4f5f7;
+}
+
+.blog .post .post-content td {
+ padding: 0.5rem;
+}
+
+.blog .post .post-content th {
+ padding: 0.7rem;
+ background: #e1e4e9;
Review comment:
Let's rather use the CSS variables here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596548540
Hey! I'm so sorry, the new branch I had made was branching out from this one, instead of the master. I have made a new branch and done the commits related to the other issue. I have opened a new pull request for that.
What should I do about this PR? Should I revert back the changes and commit just the blog.css file again, or is it better if I close this PR and raise a new one (since changes are small, I can redo them easily)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596542275
> Hi, I have made those changes in a separate branch. Is it affecting this PR as well?
Yeah, you can see the commits included in this pull request on the Commits page:
https://github.com/apache/camel-website/pull/181/commits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596635321
@aashnajena perfect, thanks, let's wait for the preview to make sure everything looks good and then we can merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596634937
Hi, I have rebased this branch. Now you should only be able to see commits related to [this](https://issues.apache.org/jira/browse/CAMEL-14674) issue. Thanks for helping me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596665639
Hey! I wasn't sure if I should remove those, since they weren't my commits. I have removed them now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #181: CAMEL-14674:
Nicer table design for the blog post
Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #181: CAMEL-14674: Nicer table design for the blog post
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596540030
> Perhaps split into two pull requests
Hi, I have made those changes in a separate branch. Is it affecting this PR as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#181: Aashna changes
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #181: Aashna changes
URL: https://github.com/apache/camel-website/pull/181#discussion_r389618002
##########
File path: antora-ui-camel/src/css/blog.css
##########
@@ -99,6 +99,25 @@ article.blog p {
white-space: pre-wrap;
}
+.blog .post .post-content table {
+ width: 100%;
+ text-align: center;
+ margin-bottom: 1rem;
+}
+
+.blog .post .post-content tr:nth-child(even) {
+ background: #f4f5f7;
Review comment:
Can we use one of the variables in `vars.css` instead? `--color-smoke-50` looks similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #181: Aashna changes
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #181: Aashna changes
URL: https://github.com/apache/camel-website/pull/181#issuecomment-596487950
Thanks @aashnajena, note that you can edit the title of the pull request so when reviewing folk know what the pull request is about. In this case a good title would be `CAMEL-14674: Nicer table design for the blog post`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services