[GitHub] [accumulo] alerman commented on a change in pull request #1457: fixes #1456 by adding rate limiter to shutdown queue

[GitBox <gi...@apache.org>]

alerman commented on a change in pull request #1457: fixes #1456 by adding rate limiter to shutdown queue
URL: https://github.com/apache/accumulo/pull/1457#discussion_r356806689
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
 ##########
 @@ -1202,7 +1205,9 @@ public void run() {
               try {
                 TServerConnection connection = tserverSet.getConnection(server);
                 if (connection != null) {
-                  connection.halt(masterLock);
+                  if (rateLimiter.tryAcquire()) {
 
 Review comment:
   @keith-turner  Yes, That isn't a change to what happens now. If it fails to issue the shutdown, the sever is removed and status is attempted three more times

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services