You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "CuteChuanChuan (via GitHub)" <gi...@apache.org> on 2025/07/02 12:50:07 UTC

[PR] Build: Fix error-prone warning [iceberg]

CuteChuanChuan opened a new pull request, #13447:
URL: https://github.com/apache/iceberg/pull/13447

   Summary:
   
   Closes https://github.com/apache/iceberg/issues/13178
   
   Details:
   
   - ParserContext: Make Builder constructor private to avoid ImplicitPublicBuilderConstructor
   
   Verification:
   
   Run ./gradlew clean build -x test -x integrationTest --no-build-cache to ensure no ErrorProne warnings
   Run ./gradlew :iceberg-core:test to verify modifications don't break existing functionality
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Fix error-prone warning [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #13447:
URL: https://github.com/apache/iceberg/pull/13447#issuecomment-3028553811

   Thanks @CuteChuanChuan for fixing this, and thanks @nastra, @ajantha-bhat  and @singhpk234 for the review 🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Fix error-prone warning [iceberg]

Posted by "CuteChuanChuan (via GitHub)" <gi...@apache.org>.
CuteChuanChuan commented on PR #13447:
URL: https://github.com/apache/iceberg/pull/13447#issuecomment-3028122453

   Hi @nastra ,
   
   The test `testParallelPartialProgressWithMaxCommitsLargerThanTotalGroupCount` failed in CI but passes when I run it locally with the same changes.
   
   Could we re-run the CI? If it fails again, I'm happy to investigate further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Fix error-prone warning [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #13447:
URL: https://github.com/apache/iceberg/pull/13447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org