You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/15 07:40:16 UTC
[GitHub] [pulsar] BewareMyPower opened a new pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
BewareMyPower opened a new pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568
Fixes #8513
### Motivation
Tests of `KeySharedConsumerTest` are likely to fail. From the log we can see sometimes the consumer didn't receive all messages.
For example logs in #8513 we can see
- `testMultiTopics`, 3000 messages were sent, but the messages per consumer is `{0 => 0, 1 => 529, 2 => 621}`. Only 1150 messages were received.
- `testOrderingKeyPriority`, 1000 messages were sent, but the messages per consumer is `{0 => 0, 1 => 270, 2 => 264}`. Only 534 messages were received.
It could also be seen in other tests of `KeySharedConsumerTest` when tests are running in CI.
### Modifications
- Increase the receive timeout to make sure consumers can receive all messages
- Remove the check for messages distribution, it's a broker's thing and has been tested in Java client test `KeySharedSubscriptionTest`.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727789569
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727803413
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727796254
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727674855
@BewareMyPower Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727674739
@codelipenghui I agree. I'll restore the check because the main flaky reason is not the distribution check but the consumer cannot receive all messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727748879
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727671704
> Remove the check for messages distribution, it's a broker's thing and has been tested in Java client test KeySharedSubscriptionTest. Instead, it checks the total number of received messages.
@BewareMyPower I think we also should try the message distribution for CPP clients. I would rather think of it should be an integration test, we should ensure that the correctness of the client's behavior does not rely on server-side testing. If the current method causes frequently test instability, I think we can create an issue to find more effective testing methods and merge this PR first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727726853
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #8568: [C++] Fix flaky tests of KeySharedConsumerTest
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727718898
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org