[GitHub] egor-ryashin commented on a change in pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose

[GitBox <gi...@apache.org>]

egor-ryashin commented on a change in pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose
URL: https://github.com/apache/incubator-druid/pull/7038#discussion_r255304537
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseFactory.java
 ##########
 @@ -437,14 +550,17 @@ public boolean isClosed()
     /**
      * Checks the request for a producer ID and sequence value.  If the producer ID is specified, a corresponding
      * sequence value must be specified as well.  If the incoming sequence is less than or equal to the last seen
-     * sequence for that producer ID, the request is ignored
+     * sequence for that producer ID, the request is ignored.
+     *
+     * This method might be called concurrently from multiple threads.
      *
      * @param req Http request
      * @param responseContentType Response content type
      * @param responseMapper Response object mapper
-     * @return Optional of a response to return of an empty optional if the request can proceed
+     * @return a response to return or null if the request can proceed
 
 Review comment:
   `an error response or null` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org