[GitHub] [spark] amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias

[GitBox <gi...@apache.org>]

amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r352431228
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ##########
 @@ -286,6 +286,15 @@ abstract class Expression extends TreeNode[Expression] {
   override def simpleStringWithNodeId(): String = {
     throw new UnsupportedOperationException(s"$nodeName does not implement simpleStringWithNodeId")
   }
+
+  var functionAlias: String = ""
 
 Review comment:
   Argument's data types are matched in Analysis phase of planning and its optimizer's task to replace `RuntimeReplaceable`, correct me if I'm wrong.
   So, optimization rules (`ReplaceExpressions`) will never be applied on queries like `select every('true')`.
   https://github.com/apache/spark/blob/85cb388ae3f25b0e6a7fc1a2d78fd1c3ec03f341/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L130

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org