You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 16:14:05 UTC

[GitHub] [airflow] Caerbannog opened a new issue, #24928: Show a browser notification when a DAG run completes

Caerbannog opened a new issue, #24928:
URL: https://github.com/apache/airflow/issues/24928

   ### Description
   
   When the DAG grid view is open and a DAG is running, the auto-refresh already detects when all tasks end.
   We could show a web notification when this happens.
   
   Metabase does something similar when a long running process finishes. It also notifies through the favicon and the page title.
   https://github.com/metabase/metabase/issues/21247
   
   ### Use case/motivation
   
   When you are waiting for a DAG end (debugging the DAG or needing the output), you have to keep the Airflow tab in view to know when the process finishes.
   Adding a way to notifiy the user from a background tab would be more convenient.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24928: Show a browser notification when a DAG run completes

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24928:
URL: https://github.com/apache/airflow/issues/24928#issuecomment-1179158844

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Caerbannog commented on issue #24928: Show a browser notification when a DAG run completes

Posted by GitBox <gi...@apache.org>.
Caerbannog commented on issue #24928:
URL: https://github.com/apache/airflow/issues/24928#issuecomment-1180695508

   Just to be clear : I think that a 5s precision is quite sufficient.
   
   If this notification feature was enabled, it would purely be javascript code.
   When the feature is enabled, the auto-refresh wouldn't be paused when the page goes in background. The 5s requests would still fire, and when they indicate that the task finished the notification would be shown (and the requests stopped).
   
   Also, a real streaming API might not be preferrable to the current polling system. For instance we currently deploy Airflow behind a load balancer with a 60s HTTP timeout, and I suspect that few organisations in our situation would bother setting up a websocket-style channel just for below-5s-latency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi closed issue #24928: Show a browser notification when a DAG run completes

Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #24928: Show a browser notification when a DAG run completes
URL: https://github.com/apache/airflow/issues/24928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #24928: Show a browser notification when a DAG run completes

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #24928:
URL: https://github.com/apache/airflow/issues/24928#issuecomment-1180496948

   I don't think we will support this in the near-term. Right now, the auto-refresh will pause when the page is in the background, because we simply GET the same endpoint every 5 seconds or so. We don't yet have a real streaming API that we could subscribe to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org