You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by dan tran <da...@gmail.com> on 2005/05/27 08:13:43 UTC

Flaw in maven-scm-api command line expansion

Folks,

Most of maven-scm-api commands like checkin, add, tag, changelog has a
ScmFileSet argument which ultimately expands into a list of individual
files on a command line.  The finally command line becomes very long,
huge, so huge
for a larget project (like my legacy project).

I know for sure, it will break on windows and could be on unixes.

May this is the main reason, why a number of implementations just
simply ignore the ScmFileSet, and goes for the default which
most SCM systems consider as ${basedir}


Any thought?

-Dan

Re: Flaw in maven-scm-api command line expansion

Posted by dan tran <da...@gmail.com>.
So we will have another round of interface cleanup?

For now, I will try to match starteam implemention similar to svn and cvs

-D

On 5/26/05, Brett Porter <br...@apache.org> wrote:
> We discussed this online already... it is very hard to do an "excludes"
> without this happening. The best way to handle it would be to:
> - just use the directory name when all children in the directory are
> included
> - for checkin, only pass files that are modified
> - not allow excludes on some operations
> 
> I think there is already a bug in JIRA under SCM or MPSCM (if not, there
> should be).
> 
> What are your thoughts?
> 
> - Brett
> 
> dan tran wrote:
> 
> >Folks,
> >
> >Most of maven-scm-api commands like checkin, add, tag, changelog has a
> >ScmFileSet argument which ultimately expands into a list of individual
> >files on a command line.  The finally command line becomes very long,
> >huge, so huge
> >for a larget project (like my legacy project).
> >
> >I know for sure, it will break on windows and could be on unixes.
> >
> >May this is the main reason, why a number of implementations just
> >simply ignore the ScmFileSet, and goes for the default which
> >most SCM systems consider as ${basedir}
> >
> >
> >Any thought?
> >
> >-Dan
> >
> >
> >
> >
> 
>

Re: Flaw in maven-scm-api command line expansion

Posted by Brett Porter <br...@apache.org>.
We discussed this online already... it is very hard to do an "excludes" 
without this happening. The best way to handle it would be to:
- just use the directory name when all children in the directory are 
included
- for checkin, only pass files that are modified
- not allow excludes on some operations

I think there is already a bug in JIRA under SCM or MPSCM (if not, there 
should be).

What are your thoughts?

- Brett

dan tran wrote:

>Folks,
>
>Most of maven-scm-api commands like checkin, add, tag, changelog has a
>ScmFileSet argument which ultimately expands into a list of individual
>files on a command line.  The finally command line becomes very long,
>huge, so huge
>for a larget project (like my legacy project).
>
>I know for sure, it will break on windows and could be on unixes.
>
>May this is the main reason, why a number of implementations just
>simply ignore the ScmFileSet, and goes for the default which
>most SCM systems consider as ${basedir}
>
>
>Any thought?
>
>-Dan
>
>
>  
>