You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cdkrot (via GitHub)" <gi...@apache.org> on 2023/07/13 12:42:11 UTC
[GitHub] [spark] cdkrot opened a new pull request, #41987: [SPARK-44410][PYTHON][Connect] Set active session in create, not just getOrCreate
cdkrot opened a new pull request, #41987:
URL: https://github.com/apache/spark/pull/41987
### What changes were proposed in this pull request?
ML and other uses rely on _active_spark_session to find spark session.
Sessions created using getOrCreate method set this variable, but sessions created with create don't.
Update create method to set _active_spark_session.
### Why are the changes needed?
This breaks spark connect customers, such as pyspark.ml and pandas from finding created session if it was created with create.
### Does this PR introduce _any_ user-facing change?
Sessions created by create are set as current session. This is slightly different behavior then before. We can hide it under configuration flag, e.g. `create(set_active_session=False)` if undesired. In this case clients who use `create` and want to use pyspark.ml/pandas will need to update to set it to True.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41987: [SPARK-44410][PYTHON][CONNECT] Set active session in create, not just getOrCreate
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41987:
URL: https://github.com/apache/spark/pull/41987#issuecomment-1637005893
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41987: [SPARK-44410][PYTHON][Connect] Set active session in create, not just getOrCreate
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41987:
URL: https://github.com/apache/spark/pull/41987#issuecomment-1635200118
cc @grundprinzip and @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41987: [SPARK-44410][PYTHON][CONNECT] Set active session in create, not just getOrCreate
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41987: [SPARK-44410][PYTHON][CONNECT] Set active session in create, not just getOrCreate
URL: https://github.com/apache/spark/pull/41987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41987: [SPARK-44410][PYTHON][Connect] Set active session in create, not just getOrCreate
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41987:
URL: https://github.com/apache/spark/pull/41987#issuecomment-1635197616
cc @HyukjinKwon @allisonport-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cdkrot commented on pull request #41987: [SPARK-44410][PYTHON][Connect] Set active session in create, not just getOrCreate
Posted by "cdkrot (via GitHub)" <gi...@apache.org>.
cdkrot commented on PR #41987:
URL: https://github.com/apache/spark/pull/41987#issuecomment-1636077583
Should we merge this? @WeichenXu123, @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org