You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/12/12 12:42:26 UTC
[GitHub] [libcloud] alier350 opened a new pull request, #1821: Add support for af south 1 in s3 driver
alier350 opened a new pull request, #1821:
URL: https://github.com/apache/libcloud/pull/1821
## Add support for AWS af-south-1 region to S3 storage driver
### Description
We noticed the following error when running our Ansible automation on af-south-1 VMs on AWS:
```
File "/usr/local/lib/python3.8/dist-packages/libcloud/storage/drivers/s3.py", line 1134, in __init__
raise ValueError('Invalid or unsupported region: %s' % (region))
ValueError: Invalid or unsupported region: af-south-1
```
The reason for the error is missing configuration for the `af-south-1` region of AWS in the S3 driver of libcloud, which we have remediated locally and now raising this PR to contribute back to the project.
### Status
- done, ready for review (Used pylint for linting)
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1821: Add support for af south 1 in s3 driver
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1821:
URL: https://github.com/apache/libcloud/pull/1821#issuecomment-1368997803
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] alier350 commented on pull request #1821: Add support for af south 1 in s3 driver
Posted by GitBox <gi...@apache.org>.
alier350 commented on PR #1821:
URL: https://github.com/apache/libcloud/pull/1821#issuecomment-1375298623
> Merged, thanks!
Great stuff, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1821: Add support for af south 1 in s3 driver
Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1821:
URL: https://github.com/apache/libcloud/pull/1821#issuecomment-1368977503
Thank you for the contribution.
Only change needed is updating ``REGION_TO_HOST_MAP`` dictionary. Adding new classes is not needed anymore - this was old and now deprecated approach.
I will remove this new class and merge changes into trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] asfgit merged pull request #1821: Add support for af south 1 in s3 driver
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #1821:
URL: https://github.com/apache/libcloud/pull/1821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org