You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SebastianMH <gi...@git.apache.org> on 2014/08/01 08:38:01 UTC
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
GitHub user SebastianMH opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/37
Removed [optional] tag from contactFindOptions. Fixes #CB-7247
https://issues.apache.org/jira/browse/CB-7247
The parameter contactFindOptions of navigator.contacts.find is labeled optional but actually is required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SebastianMH/cordova-plugin-contacts CB-7247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit ec87861129f2933b52e05fd6eeb343002e8ac34b
Author: Sebastian Miller-Hack <se...@gmail.com>
Date: 2014-08-01T06:26:18Z
Removed [optional] tag from contactFindOptions. Fixes #CB-7247
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50993882
Reproduced this issue on both android (return error) and ios (return first contact instead of all).
Pushed fix to plugin master to explicitly define 'options' param when it is not passed. So ios, android works correct now (as well as wp8). I don't think this pull request is necessary since this is fixed, but @SebastianMH thx for catching this issue and your PR.
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;a=commit;h=413cea9d5a5def821014eaadbb85cec5213ed4c3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by SebastianMH <gi...@git.apache.org>.
Github user SebastianMH closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by SebastianMH <gi...@git.apache.org>.
Github user SebastianMH commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-51408629
I am closing this pull request since @sgrebnov committed a fix to the master branch.
Thanks @sgrebnov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by purplecabbage <pu...@gmail.com>.
We don't need an cla for a 1 line documentation fix.
Ultimately this is a defect in the plugin, and should be fixed. Documenting the quirk helps in the meantime, until it is fixed for Android and ios.
> On Aug 1, 2014, at 2:22 PM, lorinbeer <gi...@git.apache.org> wrote:
>
> Github user lorinbeer commented on the pull request:
>
> https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354
>
> Hi @sgrebnov,
>
> omitting contactFindOptions results in a errorJSON return message on Android, and I believe was replicated on iOS. Documenting the actual behavior of the plugin is essential, and this issue has caused considerable confusion to using the contacts plugin.
>
> Thanks for the pull request Sebastian, we'll pull it in as soon as your CLA is recognized by the Apache Secretary. @sgrebnov and myself may have suggestions in how to document the issue (which can be accomplished by adding commits to the origin branch of the pull request) depending on whether it is system wide, platform specific, deviation from spec, etc.
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by lorinbeer <gi...@git.apache.org>.
Github user lorinbeer commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354
Hi @sgrebnov,
omitting contactFindOptions results in a errorJSON return message on Android, and I believe was replicated on iOS. Documenting the actual behavior of the plugin is essential, and this issue has caused considerable confusion to using the contacts plugin.
Thanks for the pull request Sebastian, we'll pull it in as soon as your CLA is recognized by the Apache Secretary. @sgrebnov and myself may have suggestions in how to document the issue (which can be accomplished by adding commits to the origin branch of the pull request) depending on whether it is system wide, platform specific, deviation from spec, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50886099
Hey Sebastian, I think missing contactFindOptions means return all contacts and is correctly handled on some platforms. Is there specific platform which fails if you don't pass this parameter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---