You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/21 11:15:58 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5731:
[AIRFLOW-5117] support refreshing EKS api tokens
ashb commented on a change in pull request #5731: [AIRFLOW-5117] support refreshing EKS api tokens
URL: https://github.com/apache/airflow/pull/5731#discussion_r336960921
##########
File path: airflow/kubernetes/kube_client.py
##########
@@ -15,12 +15,48 @@
# specific language governing permissions and limitations
# under the License.
"""Client for kubernetes communication"""
+
+from typing import Optional
from airflow.configuration import conf
try:
from kubernetes import config, client
from kubernetes.client.rest import ApiException # pylint: disable=unused-import
+ from kubernetes.client.api_client import ApiClient
+ from kubernetes.client import Configuration
+ from airflow.kubernetes.refresh_config import ( # pylint: disable=ungrouped-imports
Review comment:
`isort`, which we have now added might try to re-order this, so you'll probably have to add `# isort:skip` here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services