You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:02:38 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4367: Remove cpu core from op_host_capacity when host is deleted

ravening opened a new pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367


   
   ## Description
   <!--- Describe your changes in detail -->
   
   When a host is put into maintenance mode or its deleted from
   cloud stack then delete its entries from the op_host_capacity table
   
   Currently, only memory and CPU information is deleted from the table.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   Delete a host or put a host into maintenance mode.
   All the entries related to this host in op_host_capacity should be deleted
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland merged pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-717296338


   @blueorangutan test centos7 kvm-centos7 keepenv


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-717296338


   @blueorangutan test centos7 kvm-centos7 keepenv


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-708305427


   @blueoragutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-717297821


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-717296923


   @blueorangutan test centos7 kvm-centos7 keepEnv


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-707100270


   @blueorangutn package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-703648572


   > @ravening will you backport?
   
   I will rebase with 4.14


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-709269350


   @blueoragutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-702013230


   @ravening this is a bug fix, which should be merged into 4.14 as well


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-714301267


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2259


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-712731699


   @blueoragutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-703598325


   @ravening will you backport?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-717624081


   <b>Trillian test result (tid-3082)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33552 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4367-t3082-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 293.62 | test_kubernetes_clusters.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-714287067


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-707100270


   @blueorangutn package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4367:
URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-714287743


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org