[GitHub] [echarts] Ovilia commented on a change in pull request #16026: Fix(markline): markLine shouldn't be filtered if one point is out side of the grid

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #16026:
URL: https://github.com/apache/echarts/pull/16026#discussion_r745484670



##########
File path: src/component/marker/MarkLineView.ts
##########
@@ -305,8 +306,13 @@ class MarkLineView extends MarkerView {
         const lineDrawMap = this.markerGroupMap;
         const lineDraw = lineDrawMap.get(seriesId)
             || lineDrawMap.set(seriesId, new LineDraw());
+        const clipPath = createClipPath(
+            (seriesModel.coordinateSystem as Cartesian2D), false, seriesModel
+        );
+        this.group.setClipPath(clipPath);
         this.group.add(lineDraw.group);
 
+

Review comment:
       It seems to be an extra line here.

##########
File path: src/component/marker/MarkLineView.ts
##########
@@ -192,7 +193,7 @@ function markLineFilter(
         }
     }
     return markerHelper.dataFilter(coordSys, item[0])
-        && markerHelper.dataFilter(coordSys, item[1]);
+        || markerHelper.dataFilter(coordSys, item[1]);

Review comment:
       Does this mean that if none of the two points are inside the coordSys, it should always be hidden? Conside the case when two points are outside of the coordSys, but their connecting line has some part inside the coordSys. I think it may make more sense to display the part inside of the coordSys.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org