You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/25 23:28:32 UTC
[Impala-ASF-CR] [stress] pull out QueryRunner
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12578
Change subject: [stress] pull out QueryRunner
......................................................................
[stress] pull out QueryRunner
Further refactoring to reduce the size of concurrent_select.py.
Pull out the QueryRunner class and miscellaneous utility functions.
Improve encapsulation of _metrics by adding accessor functions.
Testing:
Ran locally with various arguments including DML and random queries.
Made it sure did some binary search by deleting parts of runtime info.
Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
---
M tests/stress/concurrent_select.py
A tests/stress/query_runner.py
A tests/stress/util.py
3 files changed, 539 insertions(+), 469 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/12578/1
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2380/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 02:18:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
[stress] pull out QueryRunner
Further refactoring to reduce the size of concurrent_select.py.
Pull out the QueryRunner class and miscellaneous utility functions.
Improve encapsulation of _metrics by adding accessor functions.
Testing:
Ran locally with various arguments including DML and random queries.
Made it sure did some binary search by deleting parts of runtime info.
Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Reviewed-on: http://gerrit.cloudera.org:8080/12578
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/stress/concurrent_select.py
A tests/stress/query_runner.py
A tests/stress/util.py
3 files changed, 538 insertions(+), 469 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3906/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:04:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12578
to look at the new patch set (#3).
Change subject: [stress] pull out QueryRunner
......................................................................
[stress] pull out QueryRunner
Further refactoring to reduce the size of concurrent_select.py.
Pull out the QueryRunner class and miscellaneous utility functions.
Improve encapsulation of _metrics by adding accessor functions.
Testing:
Ran locally with various arguments including DML and random queries.
Made it sure did some binary search by deleting parts of runtime info.
Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
---
M tests/stress/concurrent_select.py
A tests/stress/query_runner.py
A tests/stress/util.py
3 files changed, 538 insertions(+), 469 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/12578/3
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py
File tests/stress/query_runner.py:
http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py@443
PS3, Line 443: def fetch_and_set_profile(cursor, report):
> Would it maybe make sense to just make this a member function of QueryRepor
I guess I was thinking of QueryReport as mostly a struct rather than a richer object.
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:21:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py
File tests/stress/query_runner.py:
http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py@79
PS2, Line 79: # TODO: other classes reach in and touch _metrics
> I fixed this, can remove the TODO
Done
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:23:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2237/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 00:12:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py
File tests/stress/query_runner.py:
http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py@79
PS2, Line 79: # TODO: other classes reach in and touch _metrics
I fixed this, can remove the TODO
http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py@279
PS2, Line 279: def _hash_result(self, cursor, timeout_unix_time, query):
This function is hideously long. I moved it untouched and will clean up in a follow-on patch.
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 18:44:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 21:26:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py
File tests/stress/query_runner.py:
http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py@443
PS3, Line 443: def fetch_and_set_profile(cursor, report):
Would it maybe make sense to just make this a member function of QueryReport?
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 21:50:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [stress] pull out QueryRunner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 17:04:53 +0000
Gerrit-HasComments: No