You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/11 13:05:20 UTC
[GitHub] [incubator-nuttx] CV-Bowen opened a new pull request, #6239: arm_createstack: fix warning for tc32 compiler.
CV-Bowen opened a new pull request, #6239:
URL: https://github.com/apache/incubator-nuttx/pull/6239
## Summary
fix warning:
common/arm_createstack.c: In function 'up_create_stack':
common/arm_createstack.c:154:11: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
## Impact
None
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6239: arm_createstack: fix warning for tc32 compiler.
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6239:
URL: https://github.com/apache/incubator-nuttx/pull/6239#discussion_r870375763
##########
arch/arm/src/common/arm_createstack.c:
##########
@@ -151,7 +151,8 @@ int up_create_stack(struct tcb_s *tcb, size_t stack_size, uint8_t ttype)
if (!tcb->stack_alloc_ptr)
{
- serr("ERROR: Failed to allocate stack, size %d\n", stack_size);
+ serr("ERROR: Failed to allocate stack, size %" PRIu32 "\n",
+ stack_size);
Review Comment:
I think we need `%z` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #6239: arm_createstack: fix warning for tc32 compiler.
Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on code in PR #6239:
URL: https://github.com/apache/incubator-nuttx/pull/6239#discussion_r870441050
##########
arch/arm/src/common/arm_createstack.c:
##########
@@ -151,7 +151,8 @@ int up_create_stack(struct tcb_s *tcb, size_t stack_size, uint8_t ttype)
if (!tcb->stack_alloc_ptr)
{
- serr("ERROR: Failed to allocate stack, size %d\n", stack_size);
+ serr("ERROR: Failed to allocate stack, size %" PRIu32 "\n",
+ stack_size);
Review Comment:
ack and done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6239: arm_createstack: fix warning for tc32 compiler.
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6239:
URL: https://github.com/apache/incubator-nuttx/pull/6239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org