You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by thunterdb <gi...@git.apache.org> on 2016/04/30 00:15:00 UTC
[GitHub] spark pull request: [WIP][SPARKR][SPARK-14831]Make the SparkR MLli...
GitHub user thunterdb opened a pull request:
https://github.com/apache/spark/pull/12789
[WIP][SPARKR][SPARK-14831]Make the SparkR MLlib API more consistent with Spark
## What changes were proposed in this pull request?
This is a work in progress, not intended to be merged.
## How was this patch tested?
This PR's goal in to check the tests against jenkins to find potential issues I missed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thunterdb/spark 14831
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12789
----
commit 93d4b56390e1df95dba53005d2902ab49e262180
Author: Timothy Hunter <ti...@databricks.com>
Date: 2016-04-29T19:18:39Z
started with glm
commit 88b3f2211c8b0d0563c22d7424c27c0de003f7ae
Author: Timothy Hunter <ti...@databricks.com>
Date: 2016-04-29T20:41:10Z
trying to add a test
commit 46d9d689e2dfd9e51e23fd4220dbca5ac398c09b
Author: Timothy Hunter <ti...@databricks.com>
Date: 2016-04-29T22:01:07Z
trying this
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215928744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57386/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215933651
**[Test build #57407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57407/consoleFull)** for PR 12789 at commit [`f57db82`](https://github.com/apache/spark/commit/f57db8230d95597d906a242724ce8869d7d489e0).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215934844
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57407/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215920856
**[Test build #57386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57386/consoleFull)** for PR 12789 at commit [`3b176d9`](https://github.com/apache/spark/commit/3b176d9f2ac5d733a434815519fb23546ca5de48).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARKR][SPARK-14831]Make the SparkR MLli...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215912536
**[Test build #57371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57371/consoleFull)** for PR 12789 at commit [`46d9d68`](https://github.com/apache/spark/commit/46d9d689e2dfd9e51e23fd4220dbca5ac398c09b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215934843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARKR][SPARK-14831]Make the SparkR MLli...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215912647
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215941277
I merged this into master. There are some minor issues that I will address in a follow-up PR:
* ml.save/load should be renamed to read.ml and write.ml to be consistent with read.df and write.df
* the param `data` should be called `df`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215928705
**[Test build #57386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57386/consoleFull)** for PR 12789 at commit [`3b176d9`](https://github.com/apache/spark/commit/3b176d9f2ac5d733a434815519fb23546ca5de48).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215928743
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARKR][SPARK-14831]Make the SparkR MLlib API...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215934813
**[Test build #57407 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57407/consoleFull)** for PR 12789 at commit [`f57db82`](https://github.com/apache/spark/commit/f57db8230d95597d906a242724ce8869d7d489e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARKR][SPARK-14831]Make the SparkR MLli...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215912649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57371/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARKR][SPARK-14831]Make the SparkR MLli...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12789#issuecomment-215896259
**[Test build #57371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57371/consoleFull)** for PR 12789 at commit [`46d9d68`](https://github.com/apache/spark/commit/46d9d689e2dfd9e51e23fd4220dbca5ac398c09b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org