You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2013/11/06 07:00:53 UTC

Re: Review Request 14973: HIVE-5655: Hive incorrecly handles divide-by-zero case

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14973/
-----------------------------------------------------------

(Updated Nov. 6, 2013, 6 a.m.)


Review request for hive and Brock Noland.


Bugs: HIVE-5655
    https://issues.apache.org/jira/browse/HIVE-5655


Repository: hive-git


Description
-------

Now the behavior for double type is consistent with that for decimal type.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java PRE-CREATION 
  ql/src/test/results/beelinepositive/udf_round.q.out 9faa1f8 
  ql/src/test/results/clientpositive/udf_round.q.out db87fe6 
  ql/src/test/results/clientpositive/udf_round_2.q.out 457d074 
  ql/src/test/results/clientpositive/vectorization_13.q.out f327566 
  ql/src/test/results/clientpositive/vectorization_short_regress.q.out 68a05b2 

Diff: https://reviews.apache.org/r/14973/diff/


Testing
-------

Added new test cases. Updated a few existing tests.


Thanks,

Xuefu Zhang