You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2026/10/12 03:24:14 UTC

Re: [PR] perf(cluster): reuse subkey iterator during migration [kvrocks]

jihuayu commented on code in PR #3625:
URL: https://github.com/apache/kvrocks/pull/3625#discussion_r4244424244


##########
src/storage/iterator.h:
##########
@@ -32,23 +32,30 @@ class SubKeyIterator {
   explicit SubKeyIterator(engine::Context &ctx, rocksdb::ReadOptions read_options, RedisType type, std::string prefix);
   ~SubKeyIterator() = default;
   bool Valid() const;
-  void Seek();
+  // Returns true when positioning required a RocksDB seek.
+  bool Seek();

Review Comment:
   I'm a bit concerned about changing the semantics of `Seek` here. Would it be better to use a separate function for this behavior? @wengsht @LindaSummer 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org