[jira] [Resolved] (IO-696) IOUtils.toByteArray throws inconsistent exceptions

["Gary D. Gregory (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved IO-696.
--------------------------------
    Fix Version/s: 2.9.0
       Resolution: Fixed

> IOUtils.toByteArray throws inconsistent exceptions
> --------------------------------------------------
>
>                 Key: IO-696
>                 URL: https://issues.apache.org/jira/browse/IO-696
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: ackelcn
>            Priority: Major
>             Fix For: 2.9.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The code of this method is as follows:
> {code:java}
> public static byte[] toByteArray(final InputStream input, final int size) throws IOException {        
>       if (size < 0) {
>             throw new IllegalArgumentException("Size must be equal or greater than zero: " + size);
>         }        if (size == 0) {
>             return new byte[0];
>         }        final byte[] data = new byte[size];
>         int offset = 0;
>         int read;        while (offset < size && (read = input.read(data, offset, size - offset)) != EOF) {
>             offset += read;
>         }        
>         if (offset != size) {
>             throw new IOException("Unexpected read size. current: " + offset + ", expected: " + size);
>         }        return data;
>     }
> {code}
> When size is below zero, it throws IllegalArgumentException, but when size is not equal to offset, it throws IOException. It is somewhat confusing. It shall throw IOException in both cases, in that both cases check legal sizes. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)