You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/23 22:03:57 UTC

[GitHub] [helix] jiajunwang commented on pull request #1712: Fix test TestResourceChangeDetector.

jiajunwang commented on pull request #1712:
URL: https://github.com/apache/helix/pull/1712#issuecomment-825947484


   > Question: could you briefly comment on how this test is fixed, since the description doesn't go into much details?
   > 
   > It looks like
   > 
   > ```
   > _dataProvider.notifyDataChange(ChangeType.IDEAL_STATE);
   > _dataProvider.refresh(_dataAccessor);
   > ```
   > 
   > is the key change?
   
   Yeah, you are right. I have added more descriptions. Please check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org