Re: [PR] refactor!: avoid hard dep to tokio rt [opendal]

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #4061:
URL: https://github.com/apache/opendal/pull/4061#discussion_r1464297029


##########
core/Cargo.toml:
##########
@@ -250,8 +250,7 @@ reqwest = { version = "0.11.18", features = [
 ], default-features = false }
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
-# TODO: remove `rt` after https://github.com/apache/opendal/issues/3948
-tokio = { version = "1.27", features = ["sync", "rt"] }
+tokio = { version = "1.27", features = ["sync"] }

Review Comment:
   > if our upstream dependencies include `rt`, it may still detect this feature.
   
   This PR is still meaningful that we are not the blocker for other projects to remove `tokio/rt` anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org