You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/22 22:23:01 UTC
[GitHub] [calcite] vlsi opened a new pull request #1682: [CALCITE-3623]
Replace Spotless with Autostyle
vlsi opened a new pull request #1682: [CALCITE-3623] Replace Spotless with Autostyle
URL: https://github.com/apache/calcite/pull/1682
See https://issues.apache.org/jira/browse/CALCITE-3623
Spotless has certain drawbacks:
1) It is not able to verify license headers for non-Java files. For instance, it skips `package-info.java`, it skips `*.kts` and so on :(
2) Its error messages are too verbose. Sometimes it prints the full stacktrace when just one line was enough: "file X line Y column Z has error: ..."
3) It uses unsafe Gradle APIs, so it will be incompatible with Gradle 7.0
I suggest to replace it with https://github.com/autostyle/autostyle
The new findings are:
* `*.kts` files contained extra whitespace after license header (all the other files did not)
* `buildext.gradle.kts` used wrong header (Spotless was not able to verify `kts` files :( )
Note: the PR is using "staged repository" (see `settings.gradle.kts`) which of course will be replaced with regular Gradle Plugin Portal (like all the other plugins)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi merged pull request #1682: [CALCITE-3623] Replace
Spotless with Autostyle
Posted by GitBox <gi...@apache.org>.
vlsi merged pull request #1682: [CALCITE-3623] Replace Spotless with Autostyle
URL: https://github.com/apache/calcite/pull/1682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services