[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1952: IGNITE-19290 Removing garbage from the partition, taking into account the safe time

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #1952:
URL: https://github.com/apache/ignite-3/pull/1952#discussion_r1173471244


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -88,25 +89,31 @@ public class PartitionListener implements RaftGroupListener {
     /** Storage index tracker. */
     private final PendingComparableValuesTracker<Long> storageIndexTracker;
 
+    /** Low watermark supplier, will return {@code null} if no low watermark has been assigned yet. */
+    private final Supplier<HybridTimestamp> lowWatermarkSupplier;
+
     /**
      * The constructor.
      *
      * @param partitionDataStorage The storage.
      * @param safeTime Safe time tracker.
      * @param storageIndexTracker Storage index tracker.
+     * @param lowWatermarkSupplier Low watermark supplier, will return {@code null} if no low watermark has been assigned yet.
      */
     public PartitionListener(
             PartitionDataStorage partitionDataStorage,
             StorageUpdateHandler storageUpdateHandler,
             TxStateStorage txStateStorage,
             PendingComparableValuesTracker<HybridTimestamp> safeTime,
-            PendingComparableValuesTracker<Long> storageIndexTracker
+            PendingComparableValuesTracker<Long> storageIndexTracker,
+            Supplier<HybridTimestamp> lowWatermarkSupplier

Review Comment:
   Try to fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org