[jira] [Commented] (HBASE-5425) Punt on the timeout doesn't work in BulkEnabler#waitUntilDone (master's EnableTableHandler)

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210122#comment-13210122 ] 

Hadoop QA commented on HBASE-5425:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514958/HBASE-5425.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/979//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/979//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/979//console

This message is automatically generated.
                
>  Punt on the timeout doesn't work in BulkEnabler#waitUntilDone (master's EnableTableHandler)
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5425
>                 URL: https://issues.apache.org/jira/browse/HBASE-5425
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.90.5, 0.92.0
>            Reporter: terry zhang
>         Attachments: HBASE-5425.patch
>
>
> please take a look at the code below in EnableTableHandler(hbase master):
> {code:title=EnableTableHandler.java|borderStyle=solid}
>     protected boolean waitUntilDone(long timeout)
>     throws InterruptedException {
>     
>       .....
>       int lastNumberOfRegions = this.countOfRegionsInTable;
>       while (!server.isStopped() && remaining > 0) {
>         Thread.sleep(waitingTimeForEvents);
>         regions = assignmentManager.getRegionsOfTable(tableName);
>         if (isDone(regions)) break;
>         // Punt on the timeout as long we make progress
>         if (regions.size() > lastNumberOfRegions) {
>           lastNumberOfRegions = regions.size();
>           timeout += waitingTimeForEvents;
>         }
>         remaining = timeout - (System.currentTimeMillis() - startTime);
>     ....
>     }
>     private boolean isDone(final List<HRegionInfo> regions) {
>       return regions != null && regions.size() >= this.countOfRegionsInTable;
>     }
> {code} 
> We can easily find out if we let lastNumberOfRegions = this.countOfRegionsInTable , the function of punt on timeout code will never be executed. I think initlize lastNumberOfRegions = 0 can make it work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira