You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/02 08:33:58 UTC

[GitHub] piiswrong commented on a change in pull request #8915: NVLink communication pattern updated

piiswrong commented on a change in pull request #8915: NVLink communication pattern updated 
URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r154491419
 
 

 ##########
 File path: src/kvstore/comm.h
 ##########
 @@ -675,6 +703,14 @@ class CommDevice : public Comm {
       return std::get<1>(a).Size() > std::get<1>(b).Size();
     });
 
+    std::vector<Context> g1, g2;
+    for (auto& d : devs) {
+        if (d.dev_id < 4) g1.push_back(d);
 
 Review comment:
   Can we decide this by querying cuda instead of magic numbers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services