You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/29 03:32:08 UTC

[GitHub] [orc] guiyanakuang commented on a change in pull request #887: ORC-976: Optimize compute zigzagliterals

guiyanakuang commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697949572



##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -545,14 +547,10 @@ private void determineEncoding() {
 
   private void computeZigZagLiterals() {
     // populate zigzag encoded literals
-    long zzEncVal = 0;
-    for (int i = 0; i < numLiterals; i++) {
-      if (signed) {
-        zzEncVal = utils.zigzagEncode(literals[i]);
-      } else {
-        zzEncVal = literals[i];
+    if (signed) {

Review comment:
       I quite agree. fix in 7de084b




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org