You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Oleksiy Sayankin <ol...@gmail.com> on 2014/10/25 15:28:48 UTC
Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not working.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Repository: sqoop-sqoop2
Description
-------
Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
Diff: https://reviews.apache.org/r/27190/diff/
Testing
-------
Thanks,
Oleksiy Sayankin
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/#review59228
-----------------------------------------------------------
Let's keep the generic jdbc connector as simple as possible and as generic as possible. Removing the parenthesis addresses several large database systems. If any other datasources that provide a JDBC driver have difficulty with this new syntax, we can create a connector that specifically handles that particular datasource.
- Abraham Elmahrek
On Oct. 29, 2014, 6:15 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27190/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 6:15 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/BaseJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
>
> Diff: https://reviews.apache.org/r/27190/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/#review59245
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 30, 2014, 5:43 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27190/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 5:43 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
>
> Diff: https://reviews.apache.org/r/27190/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/
-----------------------------------------------------------
(Updated Окт. 30, 2014, 8:35 п.п.)
Review request for Sqoop, Abraham Elmahrek and Gwen Shapira.
Repository: sqoop-sqoop2
Description
-------
Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
Diff: https://reviews.apache.org/r/27190/diff/
Testing
-------
Thanks,
Oleksiy Sayankin
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 5:43 p.m.)
Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
Changes
-------
Just removed unnecessary parenthesis instead of great code changes
Repository: sqoop-sqoop2
Description
-------
Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
Diffs (updated)
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
Diff: https://reviews.apache.org/r/27190/diff/
Testing
-------
Thanks,
Oleksiy Sayankin
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 6:15 p.m.)
Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
Changes
-------
Renamed IBaseJdbcExecutor -> BaseJdbcExecutor
Repository: sqoop-sqoop2
Description
-------
Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
Diffs (updated)
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/BaseJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
Diff: https://reviews.apache.org/r/27190/diff/
Testing
-------
Thanks,
Oleksiy Sayankin
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/#review58526
-----------------------------------------------------------
I think just the parenthesis can just be removed: http://stackoverflow.com/questions/25969/sql-insert-into-values-select-from.
- Abraham Elmahrek
On Oct. 25, 2014, 1:44 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27190/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 1:44 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
>
> Diff: https://reviews.apache.org/r/27190/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Qian Xu <sx...@googlemail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/#review58552
-----------------------------------------------------------
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java
<https://reviews.apache.org/r/27190/#comment99621>
Prefix "I" for interface does not follow name convention of the project.
Imagine that when changing from an abstract class to an interface a coding convention with prefix I implies renaming all the occurrences of the class.
- Qian Xu
On Oct. 25, 2014, 9:44 p.m., Oleksiy Sayankin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27190/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 9:44 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
>
> Diff: https://reviews.apache.org/r/27190/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleksiy Sayankin
>
>
Re: Review Request 27190: SQOOP-1383 - Sqoop2: MSSQL Export not
working.
Posted by Oleksiy Sayankin <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27190/
-----------------------------------------------------------
(Updated Окт. 25, 2014, 1:44 п.п.)
Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
Repository: sqoop-sqoop2
Description
-------
Added MsSqlServerJdbcExecutor to implement MSSQL server based queries.
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 9fd2e4f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java c5faa09
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java ef39cdc
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java f62339f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 3f9aa9b
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 96818ba
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/IBaseJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/JdbcExecutorFactory.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/MsSqlServerJdbcExecutor.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/CommonJdbcExecutorTest.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java e10a5b4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java d55b0f1
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java aa1c4ff
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java a7ed6ba
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java a33fa36
Diff: https://reviews.apache.org/r/27190/diff/
Testing
-------
Thanks,
Oleksiy Sayankin